r7-labs / r7.dnn.extensions Goto Github PK

https://github.com/mixerp/MixERP.Net.VCards
https://github.com/pmengal/MailSystem.NET

Basic implementation:

using System.Collections.Generic;
using System.Linq;

namespace R7.Dnn.UserHtml.Models
{
    public static class EnumerableExtensions
    {
        public static bool IsNullOrEmpty<T> (this IEnumerable<T> source) =>
           source == null || !source.Any ();
    }
}

More advanced implementation would contain ICollection<T>.Count checks for better performance. Example: http://blog.vkuznetsov.ru/posts/2011/08/31/csharp-ienumerable-isnullorempty

Roman,
Hello. I just installed the latest version of your R7 module. I'm getting an error message. I'm running dnn 8.0.1.

Deleting file safely includes counting file references, which stored:

1. In the DNN content items
2. In the database table
3. In the HTML code (links)

Extension which provide safe file deletion (presumably with the corresponding content) will need to:

• Get DNN content items related to the file
• Get database records related to the file
• If file is referenced by any content items or records, which is not about to be deleted along with the file, that file should not be deleted
• If file is referenced only by content items or records, which is just about to be deleted along with the file, that file can be "safely" deleted
• Probably it's better to try to delete content item/database records first, and if succeed - delete the file.

I think we could provide API endpoint for p.1, while concrete extension should be responsible for implementing p.2 and general algorithm. Implementation of p.3 is problematic.

Allow to cache with provided cache key, timeout and cache priority. Then cache is cleared, config need to re-read from config file.

Need to be more simple and flexible (more configuration options, potential support for Bootstrap 4)

Related issues: GH-13

Enables page refresh on closing popup, i.e. then user trigger some data changes on server. May have issues in mobile browsers.

Reference code: https://github.com/dnnsoftware/Dnn.Platform/blob/d988e269c2d93b86edf8392e816bae54b903df86/Website/js/Debug/dnn.modalpopup.js

// Usage:
// r7_dnnModal.enableRefresh (r7_dnnModal.getPopup (window.parent));

(function ($, window) {
  window.r7_dnnModal = {
    getPopup: function (_window) {
      return _window.jQuery("#iPopUp");
    },
    enableRefresh: function (popup) {
      popup.dialog("option", "refresh", true);
      popup.dialog("option", "close", function() {
        window.dnnModal.closePopUp(true, popup.dialog("option", "closingUrl"));
        // console.log ("custom close!");
      });
    }
  }
}) (jQuery, window);    

The R7.Dnn.Extensions name is simple and will help to resolve naming conflicts.

In order to make content review operations faster, cancel button in EditPortalModuleBase should close popup window w/o reloading the page.

Need to port ORM code from https://github.com/roman-yagodin/R7.University This will allow to reuse Entity Framework via abstractions across different R7 extensions.

EF 6.2 vs EF Core 1.1.1:

(+) Will require only 2 more assemblies installed in bin.
(+) Won't conflict with 2Sic solutions (but may conflict with others).
(+) More functionality onboard.
(-) Will consume additional resources then used with 2Sic solutions.
(-) Is a past.
(-) Poorer testing.

EF Core 1.1.1:

(-) Will require many assemblies to be installed in bin.
(+) Won't consume additional resources then used with 2Sic solutions.
(+) Is a future.
(-) Doesn't support GROUP BY.
(-) Doesn't support separate entity configurations (added in EF Core 2).
(+) Better testing (e.g. Sqlite in-memory databases).

Conslusion: It looks like EF Core is slightly better choice.

ORM functionality should be provided via separate Nuget/DNN package (R7.Dnn.Extensions.EFCore). Base library should contain only abstractions like IDataContext and IModelContext.

ViewModelContext is sounds like a context of the viewmodel, not a context for the viewmodels.

I think the library should be packaged as DNN library, so it can be installed independently from extensions what using it. Extensions should specify the library package as a dependency via manifests.

Failing to deserialize config then calling outside DNN (e.g. from WebActivator) will broke application.

Current time mark is another context in which viewmodels operate.

Burrow Razor control code from https://github.com/DNN-Connect/SkinControls

Many things are hardcoded, also code looks like it's created for some specific project - while have reusable generic parts.

Could be implemented in separate project or as part of R7.Dnn.Extensions.

• UrlHistory - store URLs in the cookie, not session.
• Allow to get folder history from URL history.

It could be useful to use ViewModelContext as a bag of references to general objects - not just DNN-related things and module settings.

GetModuleByMoniker(string moniker, int portalId) method will help to locate modules by moniker, which will simplify configuration of extensions which require to address specific module instances (the "default module").

SQL equivalent:

select * from dbo.TabModuleSettings
    where SettingName = 'Moniker' and SettingValue = 'mymodule'

GetModulesByMoniker(Func<bool,string> match, int portalId) method will help to get set of modules which moniker value match certain criteria (e.g. same prefix).

• System.Web.Mvc namespace already have ControllerBase class
• In current state, it is play role of abstract DataProvider

While we enumerate cached objects to remove by cache key, it's looks like it is possible that objects could be added to the cache in that time, so not all of them removed.

r7-labs/R7.University#225

Need to evaluate benefits/drawbacks of changing source code license to Apache 2.0 or LGPL v3+.

Extract localizer class to reuse in different scenarios.

It can use different backends (DNN, NGettext).

DNN backend will resource file root file, NGettext backend - text catalog.

Backport some code from R7.Epsilon for the case of "single" resource file for entire extension / subsystem.

DNN backend will need to implement plural forms.

NGettext backend will possibly need to implement DNN-like Host/Portal overrides. E.g. we would have several text catalogs under the hood, and try to get string from Portal one, then from Host one, and only then from System one.

Also would be nice to provide relative benchmarks of both backends.

Viewmodel context classes could reuse existing localizers.

Code to review:

• https://github.com/volgau/R7.Dnn.UserHtml/blob/master/R7.Dnn.UserHtml/EditUserHtml.ascx.cs
• https://github.com/roman-yagodin/R7.University/blob/master/R7.University.EduProgramProfiles/EditContingent.ascx.cs#L185-L194

There are too many issues with Globals.LinkClick() at the moment, so having safe replacement would be nice to avoid fixing similar issues in different projects again and again.

Issue examples:

• r7-labs/R7.University#74
• r7-labs/R7.MiniGallery#32

Current implementation via extension methods requires calling Message methods via this keyword inside module classes.

Debug package will provide debug version of assembly and the .pdb file. Last one should be packaged into the Resources.zip or separate Debug.zip inside install package.

CopyCstor not working properly then class implements an interface, which is inherited from another interface.

Possible solution:

static public IEnumerable<PropertyInfo> GetPropertiesAndInterfaceProperties(this Type type, BindingFlags bindingAttr = BindingFlags.Public | BindingFlags.Instance)
{
    if (!type.IsInterface) {
        return type.GetProperties( bindingAttr);
    }
    return type.GetInterfaces().Union(new Type[] { type }).SelectMany(i => i.GetProperties(bindingAttr)).Distinct();
}

Source:

https://stackoverflow.com/questions/358835/getproperties-to-return-all-properties-for-an-interface-inheritance-hierarchy

Control with buttons (or dropdown list) for each FolderHistory item, linked to DnnUrlControl instances or other selectors.

Control can also have buttons for: current page, last folder created, user folder, configured folders.

Then button is clicked, tries to set selector control to corresponding folder.

Related issues: #23

Things to do:

• Extract namespaces e.g. Cache
• Rename classes Utils => Helper
• Move methods between static classes / extensions

https://github.com/thecoderok/Unidecode.NET

Possibly better way to do this is just provide some kind of extension/helper which not depend on Unidecode.NET directly, but can be used along with it.

Hi Roman

We recently had a problem with telerik controls being used as a vector to hack some of our dnn instances.

We use some of your R7 DNN extensions a lot for websites we build.

I was wondering when you maybe will be putting out dnn extensions without current telerik dependencies?

Need to review current project structure ("packages", in the UML terminology):

1. Does separation by three libraries is really needed?
2. Using single unique namespace is probably better than having multiple namespaces.
3. Also, wouldn't it be better to keep extension classes in the separate namespace?