r2don / react-naver-map Goto Github PK

Initialized success, error 문구에서 ncpClientId 빼기

• https://github.com/r2don/react-naver-map/blob/db3797439bd9389f73c6869e96cdd7325246bdf9/src/hooks/useNaverMapInit/index.ts

• Marker
• Cluster

naver map host 변경(링크)

• http(s)://openapi.map.naver.com (~23.12.31까지만 유효) --> [변경] https://oapi.map.naver.com

네이버지도에서 제공하는 서브모듈도 사용할 수 있도록 수정

• https://navermaps.github.io/maps.js.ncp/docs/tutorial-4-Submodules.html

<script type="text/javascript" src="https://oapi.map.naver.com/openapi/v3/maps.js?ncpClientId=YOUR_CLIENT_ID&submodules=panorama,geocoder"></script>

중심을 좌표에 위치하게 변경

기존 composite pattern 변경 필요

hi, first of all I'm big fan of you.
i have little idea in this library

AS-IS
to access map instance, we can use useMapContext
but because of Provider is inside of Map component, map instance is accessible only from child components with the map component as a parent.

const InnerMap = () => {
    const map = useMapContext()
    return (
        ...
    )
}
const NaverMap = () => {
    return (
    <Map
      <InnerMap />
    </Map>
    )
}

TO-BE
how about change usage of useMapContext like this?

index.tsx
<MapContextProvider>
    <App />
</MapContextProvider>

App.tsx

function App() {
  const map = useMapContext();
  return (
    <Map />
  );
}

i'll make pr if you ok.

reactIcon�에 <image> 태그를 넣고 계속해서 렌더링하면 점점 쪼그라드는 이슈

• <div> 로 감싸면 해결되지만 정확한 이유는 모름