qy-h00 / pe Goto Github PK

Edit test.

Command Series:
add -n John Doe -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney
add -n John -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney
find -n

Explaination:
The 'find' command with specific fields accept empty input. But by the format definition in the UG, the name should not be empty. Such command need to be prevented or need to be explained in UG to specify 'find -n' means 'find the person with '-n'' or 'find the person with empty name'.

Screenshot:

Here the format of tag shown in the UG will confuses user that it is a command or not.

Test.

In the part of "Delete persons", description of "Prerequisites" has dots while description of "Expected" has not dot.
However, in the part of "Selecting persons", it's different.

Command Sequence:
add -n John Doe -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney
add -n John -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney
filter -n
list

Explaination:
I think it's better to explain why the list will only show the name after filter -n, since in the most situations the command should fully show the people.

Screenshot:

Explaination:
There is no a glossary explain address book but used in UG.

Screenshot:

It's better to modify "information_source:It" to "Information_source: It"

Command:
add -n John Doe -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, -a #2-25 -r University friend -t friends -t owesMoney

Explaination:
Though it's not usual for user to type -a in address, it's better to remind this in the format of address.

Screenshot:

Here it's better to not use 'press tab'. Instead, using some description such as 'some operations'.

Since the product name is A-Bash Book, would it be better to transform the AddressBook to A-Bash Book?

It's better to give a full table to show the result after Tab, since the photo shows that after TAB key, edit will become 'email' but user cannot know it from the examples table.

Screenshot:

Command Sequences:
add -n John Doe -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney
add -n John Doe -p 12345678 -e [email protected] -c Amazon -j Algorithm Engineer -a another place

Explaination:
Though it's the feature flaw inherited from AB3, duplicate name is very usual nowadays. Would you think it's better to prevent inputing the same person by double checking the value of phone number? I think it's more reasonable.

Screenshot:

The command:
add -n 123 -p 12345678 -e [email protected] -c Haha -j ?? -a nevermind

Explaination:
Though the UserGuide states that 'Names should only contain alphanumeric characters and spaces, and it should not be blank', it's not a good feature to accept names such as '123'. Would you think it's better to modify it into only accept alphabetical characters and spaces?

Screenshot:

Command Sequences:
add -n John Doe -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney
add -n ALKK -p 98765432 -e [email protected] -c Google -j Software Engineer -a 311, Clementi Ave 2, #2-25 -r University friend -t friends -t owesMoney

Explaination:
Commonly, the contact book should not accept two people with the same phone number.

Screenshot:

Explaination:
The application contains the function to email working only with internet connection, which conflicts the 4th NFR.