qwecu / tiralabra20-mapgenerator Goto Github PK

I'm not familiar with C# but a few points:

1. There seems to be some duplication of code such as

            double yCoordinate = (1.0 / (2.0 * (yf - yd)))
                * (x - xf) * (x - xf)
                + ((yf + yd) / 2.0);

being repeated here

You could extract that as a separate method and then instead of assigning a multiple values to their own variables

...you could just pass those without reassignment as args.

I'm not sure if that file is used as it seems that the class variable "s" is not defined and it's still used?

A minor point but it's really weird to see multiple languages used mixed together in the code.

It's probably a good idea to stick to English in everything code related.

There's a lot of commented out code in the version control which I guess could be considered a bad practice.

https://github.com/Qwecu/tiralabra20-mapgenerator/blob/main/mapseesharp/mapseesharp/VoronoiCalculator.cs

There's also a lot of code repetition that could be avoided with some restructuring.

Maybe move the logic here to the Edge class? It would make the VoronoiCalculator.cs less bloated and the code more readable.

All in all, the project looks good! I didn't try it as I don't have any kind of C# tooling set up but the effort really shows. My points are mostly related to the code hygiene and I guess in the scope of this course, it really is a secondary matter.

Projekti ladattu 30.11 klo 21:30

En ole ennen käyttänyt C# ja ajan puutteen vuoksi en kerennyt selvittämään miten ohjelma ajetaan joten en valitettavasti päässyt ajamaan ohjelmaa ja testejä.

Ohjelman koodi näyttää pitkälti hyvältä. Käytät aika paljon valmiita tietorakenteita kuten list jos haluat parantaa koodin tehokkuutta voit luoda omat näitä vastaavat tietorakenteet.

Jos olet vielä kiinnostunut projektin tekemisestä Javalla ja netbeans ei toimi niin kannattaa kokeilla jotain muuta IDE:tä kuten IntelliJ tai eclipse.