qwant / erdapfel Goto Github PK

Qwant Maps front-end

License: Apache License 2.0

JavaScript 62.77% Shell 0.09% Dockerfile 0.23% SCSS 11.42% Python 0.15% EJS 1.71% TypeScript 23.53% HTML 0.05% MDX 0.06%

frontend map mapbox-gl-js maps qwant qwant-maps

erdapfel's Issues

Text for Favorites and Route is overlapping in German translation

As you can see this part of the text is overlapping in the german translation

Installation issue

I'm currently trying to install the dependencies.

Node: v12.22.10
npm: 7.24.2
os: MacOs Montery 12.1

I installed mapnik using homebrew

Log:

npm WARN deprecated [email protected]: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated @babel/[email protected]: 🚨 This package has been deprecated in favor of separate inclusion of a polyfill and regenerator-runtime (when needed). See the @babel/polyfill docs (https://babeljs.io/docs/en/babel-polyfill) for more information.
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm ERR! code 1
npm ERR! path /Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik
npm ERR! command failed
npm ERR! command sh -c node-pre-gyp install --fallback-to-build
npm ERR! CXX(target) Release/obj.target/mapnik/src/mapnik_logger.o
npm ERR!   CXX(target) Release/obj.target/mapnik/src/node_mapnik.o
npm ERR! Failed to execute '/Users/myzel394/.nvm/versions/node/v12.22.10/bin/node /Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding/mapnik.node --module_name=mapnik --module_path=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
npm ERR! node-pre-gyp info it worked if it ends with ok
npm ERR! node-pre-gyp info using [email protected]
npm ERR! node-pre-gyp info using [email protected] | darwin | arm64
npm ERR! node-pre-gyp info check checked for "/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding/mapnik.node" (not found)
npm ERR! node-pre-gyp http GET https://mapbox-node-binary.s3.amazonaws.com/mapnik/v4.5.6/Release/darwin-arm64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 403 Forbidden on https://mapbox-node-binary.s3.amazonaws.com/mapnik/v4.5.6/Release/darwin-arm64.tar.gz 
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v72 ABI, unknown) (falling back to source compile with node-gyp) 
npm ERR! node-pre-gyp WARN Hit error response status 403 Forbidden on https://mapbox-node-binary.s3.amazonaws.com/mapnik/v4.5.6/Release/darwin-arm64.tar.gz 
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | darwin | arm64
npm ERR! gyp info ok 
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | darwin | arm64
npm ERR! gyp info find Python using Python version 3.9.10 found at "/opt/homebrew/opt/[email protected]/bin/python3.9"
npm ERR! gyp info spawn /opt/homebrew/opt/[email protected]/bin/python3.9
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/common.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/myzel394/Library/Caches/node-gyp/12.22.10/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/Users/myzel394/Library/Caches/node-gyp/12.22.10',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/Users/myzel394/Library/Caches/node-gyp/12.22.10/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info ok 
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | darwin | arm64
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! In file included from ../src/node_mapnik.cpp:7:
npm ERR! In file included from ../src/mapnik_vector_tile.hpp:7:
npm ERR! In file included from ../../mapnik-vector-tile/src/vector_tile_merc_tile.hpp:5:
npm ERR! ../../mapnik-vector-tile/src/vector_tile_tile.hpp:11:10: fatal error: 'mapnik/geometry/box2d.hpp' file not found
npm ERR! #include <mapnik/geometry/box2d.hpp>
npm ERR!          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
npm ERR! 1 error generated.
npm ERR! make: *** [Release/obj.target/mapnik/src/node_mapnik.o] Error 1
npm ERR! gyp ERR! build error 
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (events.js:314:20)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)
npm ERR! gyp ERR! System Darwin 21.2.0
npm ERR! gyp ERR! command "/Users/myzel394/.nvm/versions/node/v12.22.10/bin/node" "/Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding/mapnik.node" "--module_name=mapnik" "--module_path=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding" "--napi_version=8" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v72"
npm ERR! gyp ERR! cwd /Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik
npm ERR! gyp ERR! node -v v12.22.10
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok 
npm ERR! node-pre-gyp ERR! build error 
npm ERR! node-pre-gyp ERR! stack Error: Failed to execute '/Users/myzel394/.nvm/versions/node/v12.22.10/bin/node /Users/myzel394/.nvm/versions/node/v12.22.10/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding/mapnik.node --module_name=mapnik --module_path=/Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik/lib/binding --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
npm ERR! node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/myzel394/VSCodeProjects/erdapfel/node_modules/@mapbox/node-pre-gyp/lib/util/compile.js:89:23)
npm ERR! node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:314:20)
npm ERR! node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1022:16)
npm ERR! node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)
npm ERR! node-pre-gyp ERR! System Darwin 21.2.0
npm ERR! node-pre-gyp ERR! command "/Users/myzel394/.nvm/versions/node/v12.22.10/bin/node" "/Users/myzel394/VSCodeProjects/erdapfel/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
npm ERR! node-pre-gyp ERR! cwd /Users/myzel394/VSCodeProjects/erdapfel/node_modules/mapnik
npm ERR! node-pre-gyp ERR! node -v v12.22.10
npm ERR! node-pre-gyp ERR! node-pre-gyp -v v1.0.1
npm ERR! node-pre-gyp ERR! not ok

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/myzel394/.npm/_logs/2022-02-11T07_33_01_935Z-debug.log

Picture placement top poi panel

Hey,
really cool that you integrated pictures of POIs in your sidebar. Would it be possible to place the images on top like Google Maps?

Style in Qwant:

Thanks for this nice product.
Best regards
Jonas

Second hand shops or recycling stores have different opening hours for buying and collecting hours. So in OpenStreetMap, both opening_hours and collection_times are filled. It could be great if collecting times also appear in Qwant Maps.

Swiping on info panel doesn't work correctly on iOS

On iOS 12, swiping up or down on the info panel scrolls the whole page, making it difficult to drag. See the attached example:
qwant_maps_bug.MP4.zip

Can't make housenumber layer to be visible

Hi.
I generated vectortiles with housnemuber layer, so it definitely exists, i can see it in raw pbf data:

Then I'v added this definition to layers array in basic-style's json:

            "filter": [
                "==",
                "$type",
                "Point"
            ],
            "id": "housenumber",
            "layout": {
                "text-field": "{housenumber}",
                "text-font": [
                    "Noto Sans Regular"
                ],
                "text-size": 11,
                "visibility": "visible"
            },
            "minzoom": 14,
            "paint": {
                "text-color": "rgba(212, 177, 146, 1)"
            },
            "source": "basemap",
            "source-layer": "housenumber",
            "type": "symbol"
        },

But housenumbers just don't appear.

Should i enable additional layer in some other plaice?
Thanks in advance.

generated style.json from http://erdapfel_instance/style.json:
style.zip

Migrate this repository to Qwant organization

Replace DockerHub integration with a GitHub workflow (#1017)
Transfer ownership to Qwant, via GitHub settings
Remove references to "qwantresearch" organisation from Readme and URLs (#1020)

Add icon for charging station

Please add an icon for charging stations. As you can see here, there is no real icon (like there is an icon, but not something like this).

Getting directions from current location breaks widget

Just found out about this web app and I'm impressed!
I wanted to report that searching for a place and then trying to get the directions from the current location breaks the widget.

I am using Safari 14.0

Add some hashtag to edits coming from QwantMaps

I think it would be nice to auto add some hashtags to changesets coming from QwantMaps.

In order to do this we could append hashtags to the editUrl and ID will add those hashtags to the changeset, when uploading.
https://github.com/QwantResearch/erdapfel/blob/6dc61116207661a725229cf430ba3c6bc0cf81f2/src/adapters/poi/idunn_poi.js#L38

According to the ID API documentation something like adding &hashtags=QwantMaps to the editUrl should do the job. Though I didn't get it working when manually entering such a link.

installation issue

I am having a hard time installing erdapfel with npm

npm WARN deprecated [email protected]: Package no longer supported. Contact [email protected] for more info.
npm WARN deprecated [email protected]: Please note that v5.0.1+ of superagent removes User-Agent header by default, therefore you may need to add it yourself (e.g. GitHub blocks requests without a User-Agent header).  This notice will go away with v5.0.2+ once it is released.
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm WARN deprecated [email protected]: use String.prototype.padStart()
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno -4058
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/QwantResearch/map-style-builder.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Could you kindly help me out, as seems that some of the packs are outdated?
Tried erlier npm versions with no luck
cheers!

Can I deploy it on Vercel or Netlify?

IE 11 support drop

Checklist of technical simplifications and improvements after support of IE11 has been dropped:

Remove "Explorer 11" from babel targets
CSS vars
Simplify conditional classList.add/remove by replacing with 2-args toggle
Simplify array and string lookups with includes
Simplify custom events creation
Remove url-search-params-polyfill from dependencies
Use IntersectionObserver instead of some costly scroll listeners
Use hover media query to check if device supports mouseover interaction

To be completed.

Add orientation ray

While switching from Google Maps to Qwant Maps I realized that probably the best feature missing is the ability to see where you're looking at. It would be really nice if you could see this on the map, like you can on Google Maps. For a reference, take a look at this image: https://imag.malavida.com/mvimgbig/download-fs/google-maps-11908-1.jpg (pay attention to the blue ray coming out from the blue circle where you are standing).

I can implement this feature if you would like to, I just need your ok

(I already opened this issue here, however, I am not sure which repo is correct)

Add a miles or kilometers config option for directions

Just as a guess, I think the option could be added in a similar spot to this userLang config option.

https://github.com/QwantResearch/erdapfel/blob/ffd91d287130c13620ca3565466e25bbd6d0acea/src/adapters/direction_api.js#L44

Something like const userUnits = masq.getPreferredUnits(); maybe?

Searching bar or pub shows cafes

I've noticed when clicking the "bar" icon in the map services panel or searching bar or pub, cafes are shown on the map. Is this intended? When I click on a pub POI, it shows the correct icon and says it's a pub, but I can't use the search.

Simplify the Idunn configuration values

Previously the geocoder and the place service where different services, but they are now managed by the same API, Idunn.

The configuration values could be simplified to reflect that, meaning that we don't need a separate services.geocoder.url value https://github.com/Qwant/erdapfel/blob/master/config/default_config.yml#L31

qwant / erdapfel Goto Github PK

erdapfel's People

Contributors

Stargazers

Watchers

Forkers

erdapfel's Issues

Recommend Projects

Recommend Topics

Recommend Org