Coder Social home page Coder Social logo

Comments (7)

ahmedre avatar ahmedre commented on August 17, 2024

from quran.com-frontend.

mmahalwy avatar mmahalwy commented on August 17, 2024

Following.

from quran.com-frontend.

mahboob-awan avatar mahboob-awan commented on August 17, 2024

@mmahalwy is it fixed? it is really great for better UX.

from quran.com-frontend.

thabti avatar thabti commented on August 17, 2024

@mahboob-awan This is much more challenging, we do have it for some Reciters, but the data isn't available for the others. Change Reciter to Mohamed al-Tablawi and you should see it working.

from quran.com-frontend.

mahboob-awan avatar mahboob-awan commented on August 17, 2024

Aha, so it data specific implementation.

@sabeurthabti,thanks but here i have a question:
why not handling Ayah via "hash"? (e.g.https://quran.com/18#4)

and if we update hash for every Ayah, it can easily fix via native solution :target

from quran.com-frontend.

thabti avatar thabti commented on August 17, 2024

@mahboob-awan good question, I think the idea behind /18:4 or /18/4 rather than hash is because people reference chapters and verses in such a matter. We can add support for hash but no to removing previous implementation as people use this website to reference verses. I am happy to review a PR.

from quran.com-frontend.

mmahalwy avatar mmahalwy commented on August 17, 2024

+1 on the hash for quick reference but not removing old implementation. I don't remember what happens with react-router when adding a hash, so long as we don't get a rerender :)

from quran.com-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.