Comments (7)
from quran.com-frontend.
Following.
from quran.com-frontend.
@mmahalwy is it fixed? it is really great for better UX.
from quran.com-frontend.
@mahboob-awan This is much more challenging, we do have it for some Reciters, but the data isn't available for the others. Change Reciter to Mohamed al-Tablawi and you should see it working.
from quran.com-frontend.
Aha, so it data specific implementation.
@sabeurthabti,thanks but here i have a question:
why not handling Ayah via "hash"? (e.g.https://quran.com/18#4)
and if we update hash for every Ayah, it can easily fix via native solution :target
from quran.com-frontend.
@mahboob-awan good question, I think the idea behind /18:4
or /18/4
rather than hash is because people reference chapters and verses in such a matter. We can add support for hash but no to removing previous implementation as people use this website to reference verses. I am happy to review a PR.
from quran.com-frontend.
+1 on the hash for quick reference but not removing old implementation. I don't remember what happens with react-router when adding a hash, so long as we don't get a rerender :)
from quran.com-frontend.
Related Issues (20)
- Uncaught TypeError: Failed to execute 'addEventListener' on 'EventTarget': The callback provided as parameter 2 is not an object.
- Player is buggy
- Join slack
- Sounds do not work for the Surahs(chapters) which has more then ten ayats(verses)
- Audio starats to play from random part and start random position on page
- Audio is not loading when navigating from home page to any intrenal pages
- Slack Channel
- Slack Channel HOT 1
- Join Slack Request HOT 1
- New design is atrocious HOT 1
- Join Slack HOT 1
- Can you please add me in the slack? HOT 3
- Slack Invitation : Would love to get involved HOT 1
- Toggle for translator's name
- Xss vulnerability HOT 1
- Font rendering issue on Surah bakarah verse 72 (2:72) HOT 6
- Default translation
- Quran
- Any way to improve the Quran UI? HOT 2
- Verse recitation resumes when it shouldn't
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quran.com-frontend.