quinnherden / nofret-neck-reference Goto Github PK

Thank you for sharing this project!

You might consider designing the UI so as to allow the user to choose whether the nut of the guitar is at the left- or right-hand side of the screen. This would accommodate both lefties and righties, as well as anyone looking in a mirror at the positioning of their hands on the guitar neck while they use your app.

Similarly, it would be helpful if the user could choose whether, as their eyes travel from the top to the bottom of the screen, the guitar strings become thicker/lower or thinner/higher. (The current default presentation shows the lowest string on the bottom -- but when I'm playing the guitar, that string's on top. So I kind of have to mentally "translate" the image as though the guitar were laying face up on my lap -- in which case, I wouldn't be able to position my hand normally to play the notes!)

In addition to the usability issues mentioned above, implementing these options would provide a good exercise in designing your code so as to separate the note/string/fret mappings from the visual representation of those mappings. (Maybe you've already done that; I haven't had a chance to look at the code, and my javascript literacy is poor at best.)

I like your project so far.

It took me a minute to orient myself as to how to "see" the neck.

I recognize that the nut is a strong clue, but for beginners -- who are maybe the most likely users of your project -- I think it would be helpful to vary the relative thickness of the lines that represent the strings.