Coder Social home page Coder Social logo

argonaut's People

Contributors

qubbit avatar

Stargazers

 avatar

Watchers

 avatar  avatar

argonaut's Issues

you can reserve an app in a team you haven't joined (even when you are non-admin)

To reproduce:

  1. as an admin, set up a few teams with valid apps and environments
  2. note down the URL of some of those teams
  3. logout as admin and login as non-admin
  4. as a non-admin user, enter the URL of the team you created in step 2
  5. attempt to reserve a non-reserved environment
    expected: you should not be able to reserve apps on teams you haven't joined
    actual: you are able to reserve apps on teams you have not joined (but know the url to)

Add confirm or undo button for removing reservations

As an admin, I have the ability to remove everyone's reservations. This is nice, but if I accidentally click on a reservation from someone else, there's no way to get it back. In order to prevent accidental deletions when you are logged in as admin (or non admin for that matter), it would be nice to have a confirmation dialog or a way to undo a reservation removal.

Validation failure is hidden from the user

  1. As an admin, login to the app
  2. create a team and then click the admin link for the team you just created
  3. attempt to add an app with just the name
    expect - there would be some error message
    actual - nothing happens except you get this error in the console:
POST https://theargonaut-bay.herokuapp.com/api/teams/8/applications 422 (Unprocessable Entity)
{"errors":{"repo":["can't be blank"],"ping":["can't be blank"]}}

This happens because the fields in both app and environment can't be blank (but aren't marked as such). There is an error raised, but it's invisible to the user.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.