SmallRyeConfigBuilder does not load addDiscoveredConverters after 3.8.0.CR1 about quarkus

[quarkus-bot]

/cc @Ladicek (smallrye), @jmartisk (smallrye), @phillip-kruger (smallrye), @radcortez (smallrye)

[gsmet]

You're mentioning 3.8.0.CR1, you have the same issue with 3.7.3, right?

It would help if you could provide a simple reproducer. Thanks!

/cc @radcortez this looks concerning

[ikovalyov]

Based on my discoveres in version 3.2.6 ConfigUtils was creating SmallRyeConfigBuilder with addDiscoveredConverters being called in both build and run time.
In new version there are separate builders for build and run time and run time builder creates SmallRyeConfigBuilder without call to addDiscoveredConverters.

I think creating minimun reproducable example can take a while as we are using this code in our custom quarkus plugin.

[gsmet]

@radcortez FWIW, the important point here is that the code of the converter is generated with Gizmo.

@ikovalyov I think you should at least post how the converter is generated.

[radcortez]

Yes, we have the addDiscovered* to false in runtime to avoid the ServiceLoader. We discover the services during build time and register them directly (generated) with the builder.

That piece is done here:

quarkus/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java

Lines 194 to 282 in 6053da3

	@BuildStep
	void generateBuilders(
	ConfigurationBuildItem configItem,
	List<ConfigMappingBuildItem> configMappings,
	List<RunTimeConfigurationDefaultBuildItem> runTimeDefaults,
	List<StaticInitConfigBuilderBuildItem> staticInitConfigBuilders,
	List<RunTimeConfigBuilderBuildItem> runTimeConfigBuilders,
	BuildProducer<GeneratedClassBuildItem> generatedClass,
	BuildProducer<ReflectiveClassBuildItem> reflectiveClass) throws Exception {
	Map<String, String> defaultValues = new HashMap<>();
	// Default values from extensions @ConfigMapping
	for (ConfigClassWithPrefix runTimeMapping : configItem.getReadResult().getRunTimeMappings()) {
	defaultValues.putAll(ConfigMappings.getDefaults(runTimeMapping));
	}
	// Default values from user @ConfigMapping
	for (ConfigMappingBuildItem configMapping : configMappings) {
	defaultValues.putAll(ConfigMappings.getDefaults(configMapping.toConfigClassWithPrefix()));
	}
	// Default values from @ConfigRoot
	defaultValues.putAll(configItem.getReadResult().getRunTimeDefaultValues());
	// Default values from build item RunTimeConfigurationDefaultBuildItem override
	for (RunTimeConfigurationDefaultBuildItem e : runTimeDefaults) {
	defaultValues.put(e.getKey(), e.getValue());
	}
	// Recorded values from build time from any other source (higher ordinal then defaults, so override)
	defaultValues.putAll(configItem.getReadResult().getRunTimeValues());
	Set<String> converters = discoverService(Converter.class, reflectiveClass);
	Set<String> interceptors = discoverService(ConfigSourceInterceptor.class, reflectiveClass);
	Set<String> interceptorFactories = discoverService(ConfigSourceInterceptorFactory.class, reflectiveClass);
	Set<String> configSources = discoverService(ConfigSource.class, reflectiveClass);
	Set<String> configSourceProviders = discoverService(ConfigSourceProvider.class, reflectiveClass);
	Set<String> configSourceFactories = discoverService(ConfigSourceFactory.class, reflectiveClass);
	Set<String> secretKeyHandlers = discoverService(SecretKeysHandler.class, reflectiveClass);
	Set<String> secretKeyHandlerFactories = discoverService(SecretKeysHandlerFactory.class, reflectiveClass);
	Set<String> configCustomizers = discoverService(SmallRyeConfigBuilderCustomizer.class, reflectiveClass);
	// For Static Init Config
	Set<ConfigClassWithPrefix> staticMappings = new HashSet<>();
	staticMappings.addAll(staticSafeConfigMappings(configMappings));
	staticMappings.addAll(configItem.getReadResult().getBuildTimeRunTimeMappings());
	Set<String> staticCustomizers = new HashSet<>(staticSafeServices(configCustomizers));
	staticCustomizers.add(StaticInitConfigBuilder.class.getName());
	String staticMappingsInfoClassName = "io.quarkus.runtime.generated.StaticInitMappingsInfo";
	generateMappingsInfo(generatedClass, reflectiveClass, staticMappingsInfoClassName, staticMappings);
	generateConfigBuilder(generatedClass, reflectiveClass, CONFIG_STATIC_NAME,
	defaultValues,
	converters,
	interceptors,
	staticSafeServices(interceptorFactories),
	staticSafeServices(configSources),
	staticSafeServices(configSourceProviders),
	staticSafeServices(configSourceFactories),
	secretKeyHandlers,
	staticSafeServices(secretKeyHandlerFactories),
	staticMappingsInfoClassName,
	staticMappings,
	staticCustomizers,
	staticInitConfigBuilders.stream().map(StaticInitConfigBuilderBuildItem::getBuilderClassName).collect(toSet()));
	reflectiveClass.produce(ReflectiveClassBuildItem.builder(CONFIG_STATIC_NAME).build());
	// For RunTime Config
	Set<ConfigClassWithPrefix> runTimeMappings = new HashSet<>();
	runTimeMappings.addAll(runtimeConfigMappings(configMappings));
	runTimeMappings.addAll(configItem.getReadResult().getBuildTimeRunTimeMappings());
	runTimeMappings.addAll(configItem.getReadResult().getRunTimeMappings());
	Set<String> runtimeCustomizers = new HashSet<>(configCustomizers);
	runtimeCustomizers.add(RuntimeConfigBuilder.class.getName());
	String runtimeMappingsInfoClassName = "io.quarkus.runtime.generated.RunTimeMappingsInfo";
	generateMappingsInfo(generatedClass, reflectiveClass, runtimeMappingsInfoClassName, runTimeMappings);
	generateConfigBuilder(generatedClass, reflectiveClass, CONFIG_RUNTIME_NAME,
	defaultValues,
	converters,
	interceptors,
	interceptorFactories,
	configSources,
	configSourceProviders,
	configSourceFactories,
	secretKeyHandlers,
	secretKeyHandlerFactories,
	runtimeMappingsInfoClassName,
	runTimeMappings,
	runtimeCustomizers,
	runTimeConfigBuilders.stream().map(RunTimeConfigBuilderBuildItem::getBuilderClassName).collect(toSet()));
	reflectiveClass.produce(ReflectiveClassBuildItem.builder(CONFIG_RUNTIME_NAME).build());
	}

Maybe your generation is happening after this config build step and is not being picked up?

[ikovalyov]

Hi!
Yes, our code is generated on a runtime.
We indeed see it is triggered after executing code you mentioned.

[radcortez]

We indeed see it is triggered after executing code you mentioned.

Ok, so in that case, it is not going to be discovered by our code.

My recommendation is to directly register the converter with a RunTimeConfigBuilderBuildItem and a io.quarkus.runtime.configuration.ConfigBuilder. This may require some additional code generation because the withConverter requires a new instance of the registered Converter.

Or just turn the discovery on again in the builder, with the downside of extra operations in the native image. You probably need to add the service loader file as the native image resource manually. We don't do it automatically, because we determine everything at build time and register the converters directly to avoid that.