Coder Social home page Coder Social logo

Comments (9)

yrodiere avatar yrodiere commented on July 19, 2024 1

I am however not sure if it describes the same situation as mine - and wanted the issue to be tracked here as well, so it is easier to find for other quarkus users.

Given there is little specific to Quarkus in jpamodelgen... I'd bet on this being totally unrelated to Quarkus.

There is already a similar issue on the hibernate tracker: https://hibernate.atlassian.net/jira/software/c/projects/HHH/issues/HHH-17514 Which has a PR hibernate/hibernate-orm#7637.

Thanks for linking to the upstream issue. Let's close when we upgrade to the relevant upstream version then.

from quarkus.

yrodiere avatar yrodiere commented on July 19, 2024 1

Wait... that's wrong. https://hibernate.atlassian.net/browse/HHH-17514 affects 6.4.0, it's not fixed there. The issue is still open upstream.

Reopening...

from quarkus.

quarkus-bot avatar quarkus-bot commented on July 19, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

from quarkus.

Postremus avatar Postremus commented on July 19, 2024

There is already a similar issue on the hibernate tracker: https://hibernate.atlassian.net/jira/software/c/projects/HHH/issues/HHH-17514
Which has a PR hibernate/hibernate-orm#7637.

I am however not sure if it describes the same situation as mine - and wanted the issue to be tracked here as well, so it is easier to find for other quarkus users.

from quarkus.

Postremus avatar Postremus commented on July 19, 2024

FTR.
As a workaround, I declare a known good version of the jpamodelgen in my own dependencymanagement.

<dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.hibernate.orm</groupId>
                <artifactId>hibernate-jpamodelgen</artifactId>
                <version>6.2.13.Final</version>
            </dependency>
        </dependencies>
    </dependencyManagement>

Now I can already switch to declaring my annotationProcessors using the compiler plugin.

<build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <configuration>
                    <annotationProcessorPaths>
                        <path>
                            <groupId>org.hibernate.orm</groupId>
                            <artifactId>hibernate-jpamodelgen</artifactId>
                        </path>
                    </annotationProcessorPaths>
                </configuration>
            </plugin>
        </plugins>
    </build>

This uses my own declared version of 6.2.13.Final - and the build is succesfull. Once the bug is fixed upstream (and quarkus updated), I can simply remove the entry from my own dependency-management.

from quarkus.

geoand avatar geoand commented on July 19, 2024

Has this since been fixed?

from quarkus.

yrodiere avatar yrodiere commented on July 19, 2024

The fix was in Hibernate ORM 6.4.0, which we upgraded to in #36978, first released in Quarkus 3.7.0.CR1.

So yes it's been fixed, I just forgot to list it in the relevant PR, sorry.

Closing.

from quarkus.

geoand avatar geoand commented on July 19, 2024

Thanks!

from quarkus.

yrodiere avatar yrodiere commented on July 19, 2024

So the bug was apparently fixed somewhere between 6.4.1 and 6.4.8, see https://hibernate.atlassian.net/browse/HHH-17514. But since it was fixed by an unrelated change, I don't know which version

I don't think it matters anyway; in Quarkus, it's fixed for sure by #40102 in Quarkus 3.11.0.CR1, and should also be fixed in any version that upgrades to Hibernate ORM 6.4.8 (I'll send a PR shortly for Quarkus 3.8).

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.