Coder Social home page Coder Social logo

Comments (4)

Sgitario avatar Sgitario commented on July 18, 2024 1

What problems with JSON libraries ?

I did not investigate it enough at first and went on with the split, but later, I dove a bit deeper and identified two "problems", or rather unadressed mistakes, both of which I have been able to resolve:

  • 601 used JSON-B, whereas 602 used Jackson. I switched 601 to Jackson, but did a poor job switching annotations on entity properties which form a relationship between entities Book and Address, causing the Jackson to not serialize Book#publisherAddress, which led to failing tests. All that was needed was to use @JsonIgnore on Address#books.
  • Introducing quarkus-spring-data-rest dependency into 601 caused a collision of exported endpoints from BookResource and BookRepository. The solution was to disable automatic export of the repository endpoints using @RepositoryRestResource(exported = false).

ATM, I have a working code with both modules merged together.
I can finish the two original PRs and then file a new PR containing the merger.
@rsvoboda @Sgitario WDYT?

+1 with finish off the two PRs and then refactor them into one.

from quarkus-test-suite.

jsmrcka avatar jsmrcka commented on July 18, 2024

I ran into problems with JSON libraries when trying to combine modules 601 and 602. For now, I proceeded with migration of the two modules separately, so I'm changing this issue to deal with 601 only. The other module is addressed in #133.

from quarkus-test-suite.

rsvoboda avatar rsvoboda commented on July 18, 2024

What problems with JSON libraries ?

from quarkus-test-suite.

jsmrcka avatar jsmrcka commented on July 18, 2024

What problems with JSON libraries ?

I did not investigate it enough at first and went on with the split, but later, I dove a bit deeper and identified two "problems", or rather unadressed mistakes, both of which I have been able to resolve:

  • 601 used JSON-B, whereas 602 used Jackson. I switched 601 to Jackson, but did a poor job switching annotations on entity properties which form a relationship between entities Book and Address, causing the Jackson to not serialize Book#publisherAddress, which led to failing tests. All that was needed was to use @JsonIgnore on Address#books.
  • Introducing quarkus-spring-data-rest dependency into 601 caused a collision of exported endpoints from BookResource and BookRepository. The solution was to disable automatic export of the repository endpoints using @RepositoryRestResource(exported = false).

ATM, I have a working code with both modules merged together.
I can finish the two original PRs and then file a new PR containing the merger.
@rsvoboda @Sgitario WDYT?

from quarkus-test-suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.