Issue rendering nested HTML about markdown-to-jsx

[quantizor]

Thanks, I'll take a look in the next few days

[quantizor]

Hmm ok. I’ll see if there’s a way to do this without introducing a ton of bundle size.

…

On Tue, Apr 3, 2018 at 1:05 PM Stephan Troyer ***@***.***> wrote: Actually there are <https://daringfireball.net/projects/markdown/syntax#html>: Note that Markdown formatting syntax is not processed within block-level HTML tags. E.g., you can’t use Markdown-style *emphasis* inside an HTML block. […] Unlike block-level HTML tags, Markdown syntax *is* processed within span-level tags. Otherwise it wouldn't be possible to start with an hashtag within an element without escaping it. (For example, I would like to display the hex color code.) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#168 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy1mby0ciY4TgulKmvgin7lpvNfYCsks5tk6vtgaJpZM4TC0qM> .

[michaelryancaputo]

Just for reference, I posted some use cases here:
This is an example using 6.4.1 - https://stackblitz.com/edit/react-qugqd6
This is an example using 6.6.1 - https://stackblitz.com/edit/react-6nelfr

[quantizor]

Just a sidenote: entering "#a" crashes the compiler.

I'm not seeing that behavior btw - if you pop it into the demo site it works as expected.

[stephtr]

I'm not seeing that behavior btw - if you pop it into the demo site it works as expected.

Did you include the quotation marks and the span? On my machine it crashes the demo site.

[quantizor]

Yup, it didn't crash for me.

[quantizor]

It's possible you might be viewing a cached, older version of the site?

[stephtr]

It is for sure the most recent version offered by the server. But since it doesn't crash my local installation, it can only be an issue of outdated files.

[stephtr]

Interestingly if I run https://runkit.com/stephtr/runkit-npm-markdown-to-jsx it runs indefinitely. I will try to debug it if I have some time left.
(markdownToJsx.compiler('"<span>#</span>"'); also gets stuck on my local node installation."

[quantizor]

A fix is pushed in v6.6.1, let me know how it goes!

[stephtr]

6.6.1 fixes the crash, however the nested HTML tags still don't render correctly. Additionally, as far as I know, markdown inside HTML inside markdown is only allowed with inline elements, so when given <div>#a</div>, markdown-to-jsx should output just <div>#a</div>.

[quantizor]

There actually are no official rules relating to arbitrary html and markdown. I try to avoid white lists as much as possible in the code, since they’re pure bloat.

…

On Tue, Apr 3, 2018 at 11:04 AM Stephan Troyer ***@***.***> wrote: 6.6.1 fixes the crash, however the nested HTML tags still don't render correctly. Additionally, as far as I know, markdown inside HTML inside markdown is only allowed with inline elements, so when given <div>#a</div>, markdown-to-jsx should output just <div>#a</div>. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#168 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy1kMp8Zv7F-PRneXTDPe6JqJ2JOiHks5tk49hgaJpZM4TC0qM> .

[stephtr]

Actually there are:

Note that Markdown formatting syntax is not processed within block-level HTML tags. E.g., you can’t use Markdown-style *emphasis * inside an HTML block.
[…]
Unlike block-level HTML tags, Markdown syntax is processed within span-level tags.

Otherwise it wouldn't be possible to start with an hashtag within an element without escaping it. (For example, I would like to display the hex color code within a colored div.)

[stephtr]

Usually when mention such issues I try to help with a PR, but unfortunately at the moment I'm too busy with my other projects.

One approach would be to first convert the whole Markdown code to HTML using an existing parser (which, in contrast to simple-markdown, is able to handle HTML), which would obviate correctly implementing all rules.

[quantizor]

Yeah that was my original approach before v6, but the bundle size was massive. I’ll figure something out.

…

On Tue, Apr 3, 2018 at 2:09 PM Stephan Troyer ***@***.***> wrote: Usually when mention such issues I try to help with a PR, but unfortunately at the moment I'm too busy with my other projects. One approach would be to first convert the whole Markdown code to HTML using an existing parser (which, in contrast to simple-markdown, is able to handle HTML), which would obviate correctly implementing all rules. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#168 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy1o4IDO4kCoMDQkvu3tKhbFu0Hvk5ks5tk7rugaJpZM4TC0qM> .

[stephtr]

Ah, I just saw #159. However before keeping the actual state (messed up parsing of HTML) I would revert #156.