Comments (5)
Thank you very much for looking into it. It seems like the sorting fixes our main concern.
The regex's performance improvement was only visible in large examples with a lot of text after the self-closing element. I tested again, and I couldn't see any performance difference now.
from markdown-to-jsx.
Could you check again with the latest code? There was a sorting issue in the rules that might have contributed to this problem.
I did perf test this particular change and was getting inconclusive results https://jsperf.app/joribi/1/preview
from markdown-to-jsx.
Hey, here is a repro https://regex101.com/r/ac4mJP/1
Apparently, self closing tags cause a runaway regex and it just times out eventually if there is enough content. The fix proposed in here does fix this issue. Would you care to reopen the issue?
from markdown-to-jsx.
@Goues if you run the adjusted regex against the unit tests it bails too early, but it is a lot faster. Working on finding a happy medium.
Worth noting that the OP regex is not current (there's no \/{0}
sequence anymore). The current block HTML regex is:
/^ *(?!<[a-z][^ >/]* ?\/>)<([a-z][^ >/]*) ?([^>]*)>\n?(\s*(?:<\1[^>]*?>[\s\S]*?<\/\1>|(?!<\1\b)[\s\S])*?)<\/\1>(?!<\/\1>)\n*/i
from markdown-to-jsx.
Ok I found a variation that works better
/^ *(?!<[a-z][^ >/]* ?\/>)<([a-z][^ >/]*) ?((?:[^>]*[^/])?)>\n?(\s*(?:<\1[^>]*?>[\s\S]*?<\/\1>|(?!<\1\b)[\s\S])*?)<\/\1>(?!<\/\1>)\n*/i
Thanks all, will get this into v7
from markdown-to-jsx.
Related Issues (20)
- Can't disable HTML sanitization HOT 3
- Component is rendering too frequently, when dependencies have not changed HOT 1
- [Critical] Page freezes with this raw text HOT 4
- Reopen #568
- follow up on #520 HOT 1
- 在引用块第一位使用 kbd标签后面链接无法正常解析
- Unexpected nested list behavior
- Ordered list is not generated if there's no newline at the end
- Double line breaks (\n\n) are not converted properly HOT 2
- Error using divider with `---` HOT 1
- Empty `<style></style>` or `<style />` causes library to crash
- React 19 incompatibility
- unordered lists don't work
- How to prevent html tag shown when doing streaming
- Nested UL crash rendering
- Feature request: Handle user selection change event in rendered Markdown. Emit an event that returns the corresponding selection in plain Markdown
- include ref property to any div crashes
- type "[key: string]: any" makes extension difficult
- Editing overrides in nested markdown
- Pipe breaks the heading formatting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-to-jsx.