Coder Social home page Coder Social logo

inchoo_adwords's People

Contributors

erfanimani avatar quafzi avatar rokko11 avatar tavinus avatar wyllyan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

inchoo_adwords's Issues

README.md file and backend location

Hi there,

Thanks for maintaining this extension.
It would really be nice to have a readme file with instructions for installing and using.

It is very simple, I know. But some people may get confused like I did, looking for the backend part as it was with the original Inchoo plugin. took me some time to find the options under Sales > Google API.

Installing is not much different from any other extension, but having the info would also be nice. I installed it manually (using curl and cp -av), so not even sure modman works.

I will try to write a readme file but I am not used to github. How would you suggest I try to send any additions or new files? I fork, change and then ask for merge?

Should I just post my README.md suggestion here?

Changes from testing with Google Chrome Tag Assistant

Hi there, I installed this on a Magento CE 1.9.2 and was testing with the Tag Assistant on Chome.

It complains that the Conversion ID should not have quotation marks.

screen-shot-2016-04-07-at-5 06 40-am

The main thing is changing the file:
app/design/frontend/base/default/template/inchoo_adwords/conversion_tracking.phtml

Line 5, remove quotation marks
From:
var google_conversion_id = "<?php echo $this->getConversionId() ?>";
To:
var google_conversion_id = <?php echo $this->getConversionId() ?>;

Those notices about having the currency look bogus as the google code from AdWords does not seem to include that.

After fixing the quotations, it complains about a non-standard implementation. Maybe we can update this for the more current google code too?

screen-shot-2016-04-07-at-5 19 06-am

Cheers!
Gus

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.