Coder Social home page Coder Social logo

Comments (5)

qrilka avatar qrilka commented on July 18, 2024

Hi @flhorizon
Any suggestion are welcome but I'm not quite sure what you propose as a "patch" here. As Linus says "show me your code" :)
Also @emilaxelsson added data validation in #67 so probably he could also add his 5 cents.

from xlsx.

flhorizon avatar flhorizon commented on July 18, 2024

Hi @qrilka :)

Here's what I have so far, working for me:

flhorizon#1

I've tried to be as conservative as possible, so as not to change the contents of the list of ValidationTypeList [Text] for the existing use case.

As current lib users aren't using cell range validation, it shouldn't break anything for them.

Unless.. they are and didn't care until now that it was broken when parsing a file 🤔

(we're currently using 0.7.2 but it doesn't seem hard to port to later majors)

from xlsx.

flhorizon avatar flhorizon commented on July 18, 2024

When I have a bit of spare time I'll implement the proposal extending the param type of DataValidationTypeList over 1.0.0.x

I guess there's no way to express in semver its backporting to 0.7.x and 0.8.x 😄

I'll admit the one with the formula header linked above (flhorizon#1) is a bit... lousy and just to sidestep upgrading my team's project deps to 1.0.0.1

from xlsx.

qrilka avatar qrilka commented on July 18, 2024

Sure, take you time, small not though - I'm on vacation for a couple of weeks so could be not that fast with a response, otherwise - any contribution is welcome

from xlsx.

flhorizon avatar flhorizon commented on July 18, 2024

Hello,

I've finally ported my cellrange DV. code to master

#157

I've also needed support for absolute coordinates along the way so I've also added it too

from xlsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.