Coder Social home page Coder Social logo

Comments (3)

qrilka avatar qrilka commented on July 18, 2024

In xlsx there is only a couple of helpers to convert dates to numbers but I guess that you're right and we don't have this "feature" of Excel supported correctly :)
I'd be glad to review a PR fixing this.

from xlsx.

MarceloZabini avatar MarceloZabini commented on July 18, 2024

Thanks for such a quick reply.

At our shop we're currently using a forked xlsx that you can see at https://github.com/proda-ai/xlsx/pull/1/files. I'm not sure it fixes the problem in the right place, and it doesn't yet handle conversion from excel to UTCTime. I can submit that PR with additions that fix the other direction, and I was thinking of adding those to dateFromNumber. Are there other or better places to fix this?

I'm also not sure what we should do about numbers in excel range [1900-2-29 00:00, 1900-2-29 23:59:59...]. I think one possibility is to convert all numbers in that range into UTCTime 1900-3-1 00:00, which would at least make dateFromNumber a (non-strictly) increasing function - maybe not a requirement but probably a sensible property?

from xlsx.

qrilka avatar qrilka commented on July 18, 2024

Sounds OK to me, just needs to be documented at least :)

from xlsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.