Comments (3)
Hi @ceki
Checking back in again since we haven't gotten any feedback on the PR since it was proposed 4 months ago.
We would appreciate a review of this proposal if you (or someone else) has the time. Knowing if this proposal will be accepted or not will help us decide how to move forward.
Thanks
from logback.
Hi @enapps-enorman,
Thank you for this PR. I imagine that the suppliers would need to be created by the OSGi platform or the application itself.
How/when will these suppliers be created?
How do you intend to inject the suppliers into logback? You would need hooks in logback itself but these seem to be missing in the PR.
from logback.
Hi @ceki
Thanks for your response. This proposal was to resolve a problem discovered during work to migrate existing code from older slf4j(1.x)+logback(1.2.x) versions to the latest releases and the refactoring needed to deal with everything that had changed. For your reference, that pending PR remains at: apache/sling-org-apache-sling-commons-log#18
Thank you for this PR. I imagine that the suppliers would need to be created by the OSGi platform or the application itself. How/when will these suppliers be created?
Yes, our use case does involve some significant customization of the logback init logic for modularization. This was to support supplying the log config more dynamically based on which OSGi configuration+bundles are active in the application runtime.
For your reference, those logback integration customization details are described briefly in the documentation at: https://sling.apache.org/documentation/development/logging.html#logback-integration
How do you intend to inject the suppliers into logback? You would need hooks in logback itself but these seem to be missing in the PR.
The custom logging init code basically has a custom factory for various PatternLayout objects that programmatically populates the instance converter supplier map with the supplier lambda expressions. This output "masking" code was written by someone else and I believe the purpose was to mask certain characters in the output for https://issues.apache.org/jira/browse/SLING-11393
For your reference, the following is the method (from a pending PR) that customizes the PatternLayout with the suppliers:
https://github.com/enapps-enorman/sling-org-apache-sling-commons-log/blob/issue/SLING-11906/src/main/java/org/apache/sling/commons/log/logback/internal/MaskingMessageUtil.java#L53
Does that make sense?
from logback.
Related Issues (20)
- Class 'org.productivity.java.syslog4j.impl.net.tcp.TCPNetSyslogConfig' contains multiple setters for the same property 'facility'.
- Exception in thread "main" java.lang.NoSuchMethodError: HOT 4
- Randomly occuring NPE when logging HOT 2
- BlockingQueue<E> blockingQueue;
- License update?
- Mask or remove specific words from log line HOT 4
- Conditional expressions evaluated in a weird order causing configuration discrepancies HOT 3
- Stack Overflow in ThrowableProxy
- Using non-existent appender in root - no logging in other files HOT 1
- Archiving is triggered only when log is being written.
- SpringBoot3,JDK17 使用logback配置了<configuration debug="false">依然会打印logback内部日志 HOT 2
- How to print virtual thread name in logback HOT 1
- pattern cannot be displayed properly
- String values with an unmatched right curly brace } drop the brace and subsequent characters
- Properties in a log statement are shoved in to message in JsonEncoder
- logback 1.5.6 using in undowtow working not properly. HOT 1
- logback-classic 1.5.5 breaks springProperty handle from included xml in a spring boot app, openjdk 17 HOT 1
- LogbackValue does not implement Context correctly (1.5.7) HOT 2
- version_1.2.13 Hourly generated logs cannot be deleted
- zstandard for compression
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logback.