qbcore-framework / qb-jewelery

Jewelry Robbery For QB-Core

qb-jewelery

Jewelry Robbery For QB-Core

Server.cfg Convar Update

• Global DrawTextUi Option

setr UseTarget false

• Global Target Option

setr UseTarget true

License

QBCore Framework
Copyright (C) 2021 Joshua Eger

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <https://www.gnu.org/licenses/>

qb-jewelery's Issues

[BUG]

2 members were banned from the jewelry script for opening the same showcases even though it wasn't open for each of them.

How can we unban them?

[BUG] Error when used with qb-target

#I'm sorry if you don't understand I am not good at English

setr UseTarget false I haven't encountered a problem.

But when setr UseTarget true , when the player join to the server later it can repeatedly smash the glass cabinet multiple no limit

setr UseTarget true - no notification if u dont have a weapon on ur hand prior to activating the robbery

*** how to BUG
how to BUG initiate the theft, logout and rejoin the server. After that, before you hold the weapon You smash the mirrors a few times before holding a weapon and smash unlimited mirrors over and over.

[BUG] 10kgoldchain key update on QBCore.Shared.Items

Describe the bug
When smashing vitrines in jewelry store to get rewards, sometimes client can get Item does not exist error

To Reproduce
Steps to reproduce the behavior:

1. Go to Jewelry store
2. Third eye and smash the glass vitrines
3. Get Item does not exist when reward is 10kgoldchain

Expected behavior
Client should be given the 10kgoldchain reward

Questions (please complete the following information):

• When you last updated: Yesterday
• Are you using custom resource? which ones? No
• Have you renamed qb- to something custom? No

Additional context
I think this is related to 10kgoldchain key being renamed to tenkgoldchain in shared Items table https://github.com/qbcore-framework/qb-core/blob/main/shared/items.lua#L348

Banned when testing the script

Banned from my server when testing this script, for exploits specifically. I see it in the code.

The ban does not register in txAdmin.

Any idea on how to unban from this?

[BUG] Rewards only rewarding `tenkgoldchain`

Describe the bug
The script is calling for a single specific item to be rewarded if the otherchance is not odd. Due to this, regardless of configuration and the items added/removed to the VitrineRewards, the only possible reward when robbing the jewelry store is the tenkgoldchain. (i have completely removed the default 3 rewards, yet im still only rewarded the tenkgoldchain)

Steps to reproduce the behavior:

1. Go to 'qb-jewelery/server/main.lua' and examine lines 80-94 to find the code calling for the tenkgoldchain to be awarded if otherchance = odd (listed above and below)
2. Go in-game and attempt to rob the jewelry store
3. See error

Expected behavior
You're supposed to be able to get rewarded any of the configured items under the VitrineRewards Config section when robbing the jewelry store.

Screenshots

Questions (please complete the following information):

• When you last updated: Today, as i thought that could be the reasoning behind the unsucessful robbery attempts
• Are you using custom resource? 'qb-target'
• Have you renamed qb- to something custom? No.

Additional context
N/A for now.

Jewelry can be robbed multiple times when the player DC and RC

Just like the title says jewelry can be robbed multiple times when the player DC and RC like nonstop. pls fix this issue asap
thanks

Cop count set to 6 but still ppl can rob jewelry without any cops online

cop count not working for some reason

Smashing Cases

The target gives me the option to smash the cases but when I click on it, nothing happens.

notification

no notification if u dont have a weapon on ur hand prior to activating the robbery

server kicking people for exploit abuse and perm banning

Describe the bug
When players on my server are doing the jewelry robbery they are getting perm banned from the server reason being is attempted exploit abuse you have been perm banned by qb-jewelery for exploit abuse

To Reproduce
Steps to reproduce the behavior:
1.start the jewelry store robbery
2. smash 2/3 cabinets
3. get perm banned from the server for exploit abuse

Expected behavior
When people are doing the robberies not to be perm banned from the server i have lost 5 players after they kept getting perm banned for exploit abuse

Screenshots
I have none to add

Questions (please complete the following information):

• When you last updated: about 8 days ago
• Are you using custom resource? which ones? qb-target
• Have you renamed qb- to something custom? no

Additional context
Add any other context about the problem here.

Smasing vitrine

Vitrines dosent show as smashed when doing the jewelery robbery?

Break Cases has infinite breaks [BUG]

Describe the bug
When you rob the store and break the glass, its infinite unless you stop restart the script or exit yourself.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Jewelry Store'
2. Click on ''
3. Use this item 'weapon.' (item's name from shared.lua if applicable)
4. NONE

Expected behavior
When you break the glass it never ends giving you 100's of items until your inventory is full or you stop the animation itself

Screenshots
If applicable, add screenshots to help explain your problem.

Questions (please complete the following information):

• When you last updated: Yesterday 9/3/2022
• Are you using custom resource? zdiscord, Badger Discord, ALL Jims scripts
• Have you renamed qb- to something custom? no

Additional context
Add any other context about the problem here.

Phone Notif

it should send a notification to police officers via phone just like other robberies

Alert dont work

When i steal the jwelery the police dont recibe any alert. I see the server and clients error and i dont have any error. anyone can tell me why?

[Placeholder] Polyzone and Target Conversion

Remove blip

I'm trying to remove the blip for the players eyes but it doesn't remove with: RemoveBlip(blip) It worked for other scripts.

Suggestion

Is there a way to change the wait it calls for Police... Like i remove the current Police Alert and added in my own from Cd_dispatch. my only issue is while doing this is that when ever a person who hold in the weapon thats in the Hash it sends a call to PD rather then when they hit the glass etc... is there a way we can change the way it works so we can add our own

Double , same on line 171

qb-jewelery/config.lua

Line 166 in e45d20e

["coords"] = vector3(-624.91, -227.87, 38.05),,

[SUGGESTION] Add probability attribute to Config.VitrineRewards

Is your feature request related to a problem? Please describe.
it is related to the way the vitrineReward event in server.lua gives out rewards, the aim is to improve this logic, for instance there is more chance the player can get the 10k gold chain than getting rolex/diamond_ring/goldchain (75% vs 25%)

Describe the feature you'd like
My idea is to introduce an attribute probability for vitrine rewards, to have control and flexibility on how the event distributes rewards. It would be also easier to maintain and change how likely a player would get an item (through config)

Describe alternatives you've considered
n/a

Additional context
n/a