putnam3145 / auxmos Goto Github PK

As title. Alternate types of atmos would be good to implement. I am not familiar with them and would rather get at least one thing working first.

Not sure if this is possible already, but from scouting thought the DM code I couldn't find a simple way to disable atmos on a specific Z-level.
After updating from monstermos to auxmos, exploration levels were no longer able to be frozen so currently I am disabling atmos updates in their entirity until map generation is done.

scream in linux incompatibility

Something is preventing the /gas_reaction/react() proc from being called only on linux, lord knows what the issue might be.

Please putnam our cit-station linux savior, relieve us of our linux incompatibilities and deliver us unto a station compatible with the superior hosting option.

This one's harder to replicate. If you run a supermatter long enough, you might see all of the nitrogen get taken out of it and a large amount of heat get added to the system, causing nigh-instantaneous instability. I personally believe it's due to the byond-end implementation of passive vents, which I'm currently in the process of fixing anyway, so this is somewhat low-priority. However, if it turns out to be something more pernicious, this gets promoted to high priority.

Occurred on NSV13 (Beestation downstream) with byond 515.1604
DLL compiled with trit_fire_hook, plasma_fire_hook, generic_fire_hook, and fastmos.

thread '<unnamed>' panicked at 'scheduler context missing', C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-0.2.25\src\runtime\basic_scheduler.rs:294:31
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at 'assertion failed: c.get().is_entered()', C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-0.2.25\src\runtime\enter.rs:221:13
stack backtrace:
   0: 0x712a59a8 - bz_internal_error
thread panicked while panicking. aborting.

The first datums created after the atmospheric subsystem initializes are liable to stomp on a few gas mixture datums. The fact that you occasionally get exploding tanks on roundstart suggests this may not be unique to turfs. The fact that it's always lavaland turfs is suspect. Incrementing refcounts for every single turf registration seems to fix this, so it's likely refcounts going wrong somewhere. This only happens on restart, a newly spun-up instance of the game will not see this issue.

Hi, it's Ubuntu 20.04 here, let's start.

Everything works as it should until the moment when DreamDaemon goes into deadlock. Spontaneously, even if there is no mapload happens, however loading of maps (I mean creation of new z-levels or changing turfs to space and back) can speed up encounter of this.

Hangup occurs without any runtimes and crashes. Nothing happens at all, the server just freezes tightly with 0 cpu load and same memory usage (about 1500 megs, but sometimes more, sometimes less). SIGUSR2 also doesn't work, but it should display backtrace and other info into DD output, what means it is completely dead. So, SIGBUS on DD works though and all I could get in log from it was this information:

Backtrace after loading 15 gateways:

BUG: Crashing due to an illegal operation!
proc name: New (/datum/gas_mixture/New)
  source file: gas_mixture.dm,27
  usr: null
  src: /datum/gas_mixture (/datum/gas_mixture)
  call stack:
/datum/gas_mixture (/datum/gas_mixture): New(0)
/datum/pipeline (/datum/pipeline): reconcile air()
/datum/pipeline (/datum/pipeline): process()
Гипер-Атмос (/datum/controller/subsystem/air): process pipenets(0)
Гипер-Атмос (/datum/controller/subsystem/air): fire(0)
Гипер-Атмос (/datum/controller/subsystem/air): ignite(0)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): Loop(2)
Master (/datum/controller/master): StartProcessing(0)

Backtrace for BYOND 514.1589 on Linux:
Generated at Fri Oct 14 10:58:14 2022

DreamDaemon [0x8048000, 0x0], [0x8048000, 0x804bd94]
linux-gate.so.1 [0xf7f30000, 0xf7f30b40], [0xf7f30000, 0xf7f30b49]
linux-gate.so.1 [0xf7f30000, 0xf7f30b70], [0xf7f30000, 0xf7f30b70]
linux-gate.so.1 [0xf7f30000, 0xf7f30b40], [0xf7f30000, 0xf7f30b49]
libc.so.6 0xffe70, 0xffe9b (syscall)
libauxmos.so [0xf4f79000, 0x0], 0x1426b
libauxmos.so [0xf4f79000, 0x0], 0x58077
libauxmos.so 0x73fd0, 0x742d9
libauxmos.so [0xf4f79000, 0x0], 0xc3bc7
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343559
libbyond.so [0xf7895000, 0x0], 0x313903
libbyond.so [0xf7895000, 0x0], 0x330412
libauxmos.so [0xf4f79000, 0x0], 0xc3c43
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343e3a
libbyond.so [0xf7895000, 0x0], 0x318b4d
libbyond.so [0xf7895000, 0x0], 0x330412
libauxmos.so [0xf4f79000, 0x0], 0xc3c43
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343559
libbyond.so [0xf7895000, 0x0], 0x313903
libbyond.so [0xf7895000, 0x0], 0x330412
libauxmos.so [0xf4f79000, 0x0], 0xc3c43
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343559
libbyond.so [0xf7895000, 0x0], 0x313903
libbyond.so [0xf7895000, 0x0], 0x330412
libauxmos.so [0xf4f79000, 0x0], 0xc3c43
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343559
libbyond.so [0xf7895000, 0x0], 0x313903
libbyond.so [0xf7895000, 0x0], 0x330412
libauxmos.so [0xf4f79000, 0x0], 0xc3c43
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343559
libbyond.so [0xf7895000, 0x0], 0x313903
libbyond.so [0xf7895000, 0x0], 0x330412
libauxmos.so [0xf4f79000, 0x0], 0xc3c43
libauxlua.so [0xc79fe000, 0x0], 0x121256
libbyond.so [0xf7895000, 0x0], 0x332644
libbyond.so [0xf7895000, 0x0], 0x343559
libbyond.so [0xf7895000, 0x0], 0x315c47
libbyond.so [0xf7895000, 0x0], 0x330412

Recent proc calls:
/proc/__detect_auxtools
/proc/__detect_auxtools
/proc/__detect_auxtools
/proc/__detect_auxtools
/datum/gas_mixture/New
/datum/pipeline/proc/return_air
/datum/pipeline/proc/reconcile_air
/datum/pipeline/process
/proc/__detect_auxtools
/proc/__detect_auxtools
/proc/__detect_auxtools
/proc/__detect_auxtools
/datum/gas_mixture/New
/datum/pipeline/proc/return_air
/datum/pipeline/proc/reconcile_air
/datum/pipeline/process

Another backtrace log looks same and blames on /datum/gas_mixture/New too, but that happened without gateway spam loading, just during normal round.

Yes, I tried to use different auxmos revisions after 2.0.0 on 514.1575, 1583 and 1585 with some modifications, but with similar result as above.

Maybe it's also because we don't use the reactions hook, only "katmos", but the old version on the commit 91708eb5cf289f2176630ab168d7d4f9da830523 works without any hangups on 514.1575. On version 514.1589 works the same, though after adding crutches to the old library, maybe it will be useful for someone: https://github.com/frosty-dev/auxmos/tree/assblast

Since I could not find a working server on the latest version, I decided to use the code from several repositories using this library, for example:
yogstation13/Yogstation#13479;
Citadel-Station-13/Citadel-Station-13#15864;
https://github.com/BeeStation/BeeStation-Hornet - we use supercruise from them since extools which creates funny crashtest for atmos;

Our repo with latest auxmos is: https://github.com/frosty-dev/white/tree/0945d9327a82e160cab7a34f1f6336a652916f0a
Our auxmos (changed auxtools repo to mothblocks pr for 1588+ sigs compatibility): https://github.com/frosty-dev/auxmos

I don’t know, maybe we have too shitty code, but still I thought it right to report at least something, maybe this will help you.

Any auxmos revisions works as expected on Windows, tbh.

I can't give more detail than this because I can't figure out what the problem is. Every time I fix something nothing changes. I wanna say it's cursed, but that's nonsense. It would be nice if someone were to look into this for me, other people have a way of seeing the obvious I missed.

I have at the very least used a debugger to check if they're being called at all. They are, and both of them end up in valid states that should lead to mutation of gases, but I still see none.