ClassName and javascript:void about purescript-halogen

[jdegoes]

Will you still need to define custom class names after Boostrap and other themes have been created? It's better for class names to be semantic, and fixed, rather than ad hoc and unlimited -- this way it's easier for a designer to modify the styles.

[cryogenian]

Classnames are not fixed because I can write classes $ className <$> ["foo", "bar"].
Maybe using it can be discouraged by name unsafeClasses in example or notTypeSafeClasses

[jdegoes]

The main reason to want a string constructor is to create custom class names, right? What's the difference between ClassName "foo" and "foo"? The former is more to type, but makes it easier to keep things straight with the compiler's help (e.g. accidentally passing a non-classname where a classname is expected).

[cryogenian]

Then className should make correctness checks and returns Maybe ClassName.
Now it just wraps string in newtype. This is neither typesafe nor comfortable.

[jdegoes]

Also for javascript:void(0); I assume this is to prevent the default action on a href clicks, right?

[cryogenian]

javascript:void(0); makes cursor pointer, and makes anchor pointing exactly this page with same hash.

[jdegoes]

The cursor pointer is easy to do with css: cursor: pointer. What is the benefit of a link which points to the same page with the same hash?

[garyb]

preventDefault is the "proper" way of doing that, it'll cancel the URL change.

[cryogenian]

• preventDefault, tabindex, cursor:pointer, a:hover {text-decoration: underline}
• preventDefault, href="something"
• javascript:void(0);
• <button class="btn btn-link"></button>

They all work same way.