Select Multiple Selected does not work about purescript-halogen

[rhendric]

I think this issue is a bug in purescript-halogen-vdom; it looks like it's because in these lines, the option elements get added to the select before the select has its multiple attribute set, and it should probably be the other way around?

https://github.com/purescript-halogen/purescript-halogen-vdom/blob/e6630023500841d910f6690fa1bc6ba649ac6f15/src/Halogen/VDom/DOM.purs#L117-L118

[garyb]

I think this issue is a bug in purescript-halogen-vdom; it looks like it's because in these lines, the option elements get added to the select before the select has its multiple attribute set, and it should probably be the other way around?

Good spot! That seems very likely.

[rhendric]

Handling attributes after children was an intentional decision very early on in purescript-halogen/purescript-halogen-vdom@2ccb0b8 (I assume it's intentional because the same change was made here in both render and patch); maybe @natefaubion remembers why it should be this way? The right thing might be to handle some HTML elements differently, as inelegant as that would be.

[natefaubion]

I don't have a clear memory of why. That PR was mainly about tweaking stuff in such a way to get the compiler to generate optimal code. It's possible that before/after made a difference there (such as where the let bindings are generated). If one were implementing extensions to the vdom machine, I could maybe see effect ordering being important. By putting attrs after, you know that all children have been initialized before building parent attrs. I don't know if that's important for anyone though.