Comments (5)
it could return the fetch response
object for the main resource
from puppeteer.
Today, 'page.navigate' waits for the load
event to fire. We might need an option to wait for DOMContentLoaded
instead, though I don't know a scenario where this is useful.
from puppeteer.
example.com returns status 200 for all paths, so that non-existing-page case won't work. Is the idea to return false for non-200 status codes? I feel like the true/false should be whether or not the current page was rendered with data from that url. So 403/404/200 would be true, but timeout/brokenssl would be false.
from puppeteer.
Rather than false
, to me it seems better to reject with an Error
with a more descriptive message.
from puppeteer.
So the issue with returning true
/false
is that it's hard to decide what is a success and what is a failure. For example, navigating to a 404 page might be a valid scenario, since a lot of websites have their own custom-made 404's.
How about:
- we consider navigation failed if there's a navigation timeout or an interstitial
- anything else returns a status code for the main resource
This should address both @JoelEinbinder and @paulirish concerns. What do you guys think?
from puppeteer.
Related Issues (20)
- [Bug]: emoji font not displayed (just blank spaces) HOT 42
- [Bug]: `PerformanceNavigationTiming.type` is `navigation` after pressing back button HOT 7
- [Bug]: Error: net::ERR_FAILED HOT 2
- [Feature]: Let docker/Dockerfile use node:20-slim as the base image HOT 2
- [Bug]: #<NoSuchFrameException> occurs even when manually navigating to a page while the browser is idle in puppeteer HOT 2
- [Bug]: Error: Could not find Chrome (ver. 124.0.6367.78). HOT 2
- [Bug]: Instructions can be improved/corrected HOT 2
- Switch to macos-latest (arm64) in ci
- [Feature]: Request Initiator Chain HOT 8
- [Bug]: Could not find Chrome (ver. ${this.puppeteer.browserRevision}) on Docker HOT 7
- [Bug]: 'page.waitForTimeout' not working in Puppeteer 22.7.1 HOT 2
- [Bug]: use manifest V3 .When the file(manifest.json) carries ”content_scripts“,puppeteer.launch timeout HOT 17
- "[network.spec] network Request.resourceType should work for document type" is flaky in firefox
- ignoreHttpsErrors should be renamed to acceptInsecureCerts
- [Bug]: Redirect stops before the final destination that has an error Name Not Resolved HOT 4
- Node process is hanging after all bidi tests are finished HOT 1
- AWS lambda: running puppeteer-core 21.5.2 and @sparticuz/chromium 118.0.0 on node 18 runtime failes ONLY when my html (for PDF rendering) contains https HOT 1
- [Bug]: the parameter outline in page.pdf seems not work HOT 6
- [Bug]: PDF page numbers no longer working in headless: shell HOT 3
- [Bug]: Install error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppeteer.