publitas / react-svg-icons Goto Github PK

View Code? Open in Web Editor NEW

33.0 33.0 11.0 469 KB

JavaScript 99.97% HTML 0.03%

react-svg-icons's People

Contributors

Stargazers

Watchers

Forkers

kureev slightlytyler vgrbr loganfreeman evgeniy-legkun

react-svg-icons's Issues

Usage with Webpack

Hi,
I tried to import your module but got errors:

WARNING in ./~/recursive-readdir/~/minimatch/minimatch.js
Critical dependencies:
6:5-12 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/recursive-readdir/~/minimatch/minimatch.js 6:5-12

WARNING in ./~/babel-core/lib/transformation/file/index.js
Critical dependencies:
537:33-45 the request of a dependency is an expression
 @ ./~/babel-core/lib/transformation/file/index.js 537:33-45

WARNING in ./~/recursive-readdir/~/minimatch/LICENSE
Module parse failed: c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\LICENSE Line 1: Unexpected number
You may need an appropriate loader to handle this file type.
| Copyright 2009, 2010, 2011 Isaac Z. Schlueter.
| All rights reserved.
|
 @ ./~/recursive-readdir/~/minimatch ^\.\/.*$

WARNING in ./~/recursive-readdir/~/minimatch/README.md
Module parse failed: c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\README.md Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
| # minimatch
|
| A minimal matching utility.
 @ ./~/recursive-readdir/~/minimatch ^\.\/.*$

WARNING in ./~/babel-core/lib/transformation/file/plugin-manager.js
Critical dependencies:
141:19-31 the request of a dependency is an expression
 @ ./~/babel-core/lib/transformation/file/plugin-manager.js 141:19-31

WARNING in ./~/try-resolve/index.js
Critical dependencies:
5:24-31 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/try-resolve/index.js 5:24-31

WARNING in ./~/babel-core/lib/transformation/file/README.md
Module parse failed: c:\WORKSPACE\JS\hbg\node_modules\babel-core\lib\transformation\file\README.md Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
| ## File Transformation
|
| This is the File Transformation directory.
 @ ./~/babel-core/lib/transformation/file ^\.\/.*$

WARNING in ./~/babel-core/lib/transformation/file/options/README.md
Module parse failed: c:\WORKSPACE\JS\hbg\node_modules\babel-core\lib\transformation\file\options\README.md Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
| ## File Options
|
| This is the File Options directory.
 @ ./~/babel-core/lib/transformation/file ^\.\/.*$

WARNING in ./~/try-resolve/README.md
Module parse failed: c:\WORKSPACE\JS\hbg\node_modules\try-resolve\README.md Line 1: Unexpected token ILLEGAL
You may need an appropriate loader to handle this file type.
| # try-resolve
|
| ## Installation
 @ ./~/try-resolve ^\.\/.*$

ERROR in ./~/recursive-readdir/~/minimatch/test/caching.js
Module not found: Error: Cannot resolve module 'tap' in c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\test
 @ ./~/recursive-readdir/~/minimatch/test/caching.js 2:10-24

ERROR in ./~/recursive-readdir/~/minimatch/test/brace-expand.js
Module not found: Error: Cannot resolve module 'tap' in c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\test
 @ ./~/recursive-readdir/~/minimatch/test/brace-expand.js 1:10-24

ERROR in ./~/recursive-readdir/~/minimatch/test/extglob-ending-with-state-char.js
Module not found: Error: Cannot resolve module 'tap' in c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\test
 @ ./~/recursive-readdir/~/minimatch/test/extglob-ending-with-state-char.js 1:11-25

ERROR in ./~/recursive-readdir/~/minimatch/test/basic.js
Module not found: Error: Cannot resolve module 'tap' in c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\test
 @ ./~/recursive-readdir/~/minimatch/test/basic.js 6:10-24

ERROR in ./~/recursive-readdir/~/minimatch/test/defaults.js
Module not found: Error: Cannot resolve module 'tap' in c:\WORKSPACE\JS\hbg\node_modules\recursive-readdir\node_modules\minimatch\test
 @ ./~/recursive-readdir/~/minimatch/test/defaults.js 6:10-24

I'm using Webpack. Do you have an idea what's wrong?

Turn off manipulation of original svg file?

Hey buddy! I started using this, and love it al ready :)

I noticed that react svg icons (or possibly svg-to-react) changes the svg; it removed classes and it merged certain paths. Is it possible to cirmumvent this? I'm trying to do some CSS-magic on svg-files and this isn't helping :P Any ideas how I should do this?

TypeError: Path must be a string.

I'm getting an error that seems like it might be related to the asset path.

TypeError: Path must be a string. Received undefined while parsing file: [app]/node_modules/react-svg-icons/index.js

I have the asset path defined in package.json like this:

    "react-svg-icons": {
      "version": "^0.2.0",
      "assetPath": "img/global/svg-icons"
    },

(I've also tried variations on that path with no luck)

and everything else defined in a component file as specified by the README.

Have you encountered this or have an idea what might be the problem?

This is with React v0.14.8, node v6.1.0, and npm 3.8.6.

Doesn't support svg with style elements

I am using react-svg-icons and started encountering the error below when I added SVG files that contain style elements:

E.g.

<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
     viewBox="0 0 12.6 7.8" style="enable-background:new 0 0 12.6 7.8;" xml:space="preserve">
<style type="text/css">
    .st0{fill:none;stroke:#41d6c3;stroke-width:2;stroke-miterlimit:10;}
</style>
<polyline id="XMLID_70_" class="st0" points="11.9,7.1 6.2,1.4 0.7,6.9 "/>
</svg>

However, if I change the SVG to put the style in-line, the error goes away:

E.g.

<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
     viewBox="0 0 12.6 7.8" enable-background="new 0 0 12.6 7.8" xml:space="preserve">
<g>
  <polyline fill="none" stroke="#41d6c3" stroke-width="2" stroke-miterlimit="10" id="XMLID_70_" class="st0" points="11.9,7.1 6.2,1.4 0.7,6.9 "/>
</g>
</svg>

Error:

/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/lib/transformation/file/index.js:671
      throw err;
      ^

SyntaxError: unknown: Unexpected token (1:60)
> 1 | <svg {...params}viewBox="-12 11.3 6.1 10.7"><style>.st0{fill:#777677;}</style><path class="st0" d="M-11.3 22l-.7-.7 4.6-4.6L-12 12l.7-.7 5.4 5.4z"/></svg>
    |                                                             ^
    at Parser.pp.raise (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/parser/location.js:24:13)
    at Parser.pp.unexpected (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/parser/util.js:82:8)
    at Parser.pp.expect (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/parser/util.js:76:33)
    at Parser.pp.jsxParseExpressionContainer (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/plugins/jsx/index.js:301:8)
    at Parser.pp.jsxParseElementAt (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/plugins/jsx/index.js:370:30)
    at Parser.pp.jsxParseElementAt (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/plugins/jsx/index.js:362:30)
    at Parser.pp.jsxParseElement (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/plugins/jsx/index.js:398:15)
    at Parser.parseExprAtom (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/plugins/jsx/index.js:410:21)
    at Parser.pp.parseExprSubscripts (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:236:19)
    at Parser.pp.parseMaybeUnary (/Users/lmlewis/git/platform-ui/platform-ui/node_modules/react-svg-icons/node_modules/svg-to-react/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:217:19)

These SVG files are coming from our design team and I assume are valid SVG, but I don't know enough about SVG to be certain. Is it possible to have react-svg-icons support SVG files like these that contain style elements?

publitas / react-svg-icons Goto Github PK

react-svg-icons's People

Contributors

Stargazers

Watchers

Forkers

react-svg-icons's Issues

Usage with Webpack

Turn off manipulation of original svg file?

TypeError: Path must be a string.

Doesn't support svg with style elements

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent