ptlis / shell-command Goto Github PK

Composer raises deprecation errors when installing the package. The main concern is that it states that some classes will no longer be autoloader when composer v2.0 hits.

Not critical, however, as they only look like test classes.

Deprecation Notice: Class ptlis\ShellCommand\Test\Mocks\MockProcessTest located in ./vendor/ptlis/shell-command/tests/Unit/Mocks/MockProcessTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.8/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201 Deprecation Notice: Class ptlis\ShellCommand\Test\Mocks\MockCommandTest located in ./vendor/ptlis/shell-command/tests/Unit/Mocks/MockCommandTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.8/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201 Deprecation Notice: Class ptlis\ShellCommand\Test\Mocks\MockCommandBuilderTest located in ./vendor/ptlis/shell-command/tests/Unit/Mocks/MockCommandBuilderTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.8/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201 Deprecation Notice: Class ptlis\ShellCommand\Test\ProcessOutputTest located in ./vendor/ptlis/shell-command/tests/Unit/ProcessOutputTest.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/Cellar/composer/1.10.8/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

This is purely to make debugging a little easier when built commands return non-zero status codes.

Value set using setCwd() is not used in validateCommand(), so validation fails if relative command is not run in the same working directory.

How to test:

<?php
require __DIR__ . '/vendor/autoload.php';
$builder = (new \ptlis\ShellCommand\CommandBuilder())
        ->setCwd('/')
        ->setCommand('./bin/ls');
echo $builder->buildCommand();

This will succeed if called in /, but fail if script is called from any other directory:

PHP Fatal error:  Uncaught RuntimeException: Invalid command "./bin/ls" provided to ptlis\ShellCommand\CommandBuilder. in /app/vendor/ptlis/shell-command/src/CommandBuilder.php:180

Bug is in line 179 of CommandBuilder->buildCommand():

Hand-made patch:

-         if (!$this->environment->validateCommand($this->command) { 
+         if (!$this->environment->validateCommand($this->command, $this->cwd)) { 

Class ptlis\ShellCommand\Test\Mocks\MockCommandBuilderTest located in vendor/ptlis/shell-command/tests\Unit\Mocks\MockCommandBuilderTest.php does not comply with psr-4 autoloading standard. Skipping.

localhost > MAMP > PHP 8.1.0 + Composer 2.2.3

Thanks for the package 👏

I have a feature idea: It would be nice to have an option to change the working directory of a command.

This way an app could stay in the current working directory, but execute a binary from within another directory. This is often useful when running multiple tools which require different (relative oder absolute) entry points themself.