ptarmiganlabs / qs-jwt Goto Github PK

The logging module of qs-jwt does not currently handle error logging as well as it should.
Specifically, in some cases there is no stack trace or error message when errors occur.

This can be easily fixed by adding the following to the Winston.createLogger call:

winston.format.errors({ stack: true })

--cert-privatekey <privatekey> Certificate private key of certificate that will be used to sign the JWT. is not ideal...

Change description to

Private key of certificate that will be used to sign the JWT.

What version of QS JWT are you using?

1.12.0

What version of Node.js are you using? Not applicable if you use the standalone version of QS JWT.

N/A

What command did you use to start QS JWT?

qs-jwt create-qseow --userdir XXX --userid "exampleuser" --username "exampleuser" --useremail "" --groups "" --expires 364d --audience hLjrej784jiLE --cert-privatekey-file cert.pem

What operating system are you using?

Windows 11 Pro

What CPU architecture are you using?

x64

What Qlik Sense versions are you using?

QSEoW 202402 Patch 3

Describe the Bug

When using the following command, the payload shows the parameter value --group instead of no value, which was expected.
qs-jwt create-qseow --userdir XXX --userid "exampleuser" --username "exampleuser" --useremail "" --groups "" --expires 364d --audience hLjrej784jiLE --cert-privatekey-file cert.pem

Payload:
{
"userId": "exampleuser",
"userDirectory": "XXX",
"name": "exampleuser",
"email": "--groups",
"iat": 1718818337,
"exp": 1750267937,
"aud": "hLjrej784jiLE"
}

When using the following command, the program throws an error.
qs-jwt create-qseow --userdir XXX --userid "exampleuser" --username "exampleuser" --useremail "[email protected]" --groups "" --expires 364d --audience hLjrej784jiLE --cert-privatekey-file miklatorg.pem

Error:
error: required option '--expires ' not specified

Conclusion: It seems that either the useremail or groups parameter is not correctly handled.

Expected Behavior

That you can provide empty strings for a required parameter.

To Reproduce

Use the commands that I provided in the description of the bug.

What version of QS JWT are you using?

1.6.1

What version of Node.js are you using? Not applicable if you use the standalone version of QS JWT.

16.4.0

What command did you use to start QS JWT?

node qs-jwt.js --help

What operating system are you using?

macOS

What CPU architecture are you using?

x86_64

What Qlik Sense versions are you using?

2021-Nov

Describe the Bug

Description

"Create a JWT for use with client-managed Qlik Sense (a.k.a Qlik Sense Enterprise on Windows) or Qlik Cloud. Use --target option to target either platform."

is not correct. The --target parameter was removed in favour of having separate create-qseow and create-qscloud commands

Expected Behavior

Use something like

"Create a JWT for use with client-managed Qlik Sense (a.k.a Qlik Sense Enterprise on Windows)."

To Reproduce

No response

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency prettier to v3.3.3
• chore(deps): update dependency esbuild to ^0.23.0
• chore(deps): update dependency snyk to v1.1292.4
• fix(deps): update dependency eslint-plugin-prettier to v5.2.1
• fix(deps): update dependency winston to v3.14.1
• fix(deps): update dependency eslint to v9
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Discussed in #48

Discussed in #46

"JWTs are usually preferred over certuficates as JWTs".

Should of course be "...certificates..."