prscx / pxsiriwave9

iOS: Siri Waveform effect similar to 9

Hey! Pranav here 👋

• 🔭 I’m currently working as a Senior Technical Director at MetricStream
  • Building the next-generation of cross platform GRC Web & Mobile app experience
  • Focus on building generic and scalable infrastructure/platform which can be leveraged to build mobile apps using React Native
  • I open-source almost everything I develop and try to reply everyone needing help using my contributions
• 💬 Ask me about building scalable mobile apps, React/React Native
• 📫 How to reach me: DMs on my GMAIL

pxsiriwave9's Issues

drawRect Memory Leak

on drawRect function, occurs memory leak
please add release functions.

CGPathRelease(path);
... ...
CGColorSpaceRelease(colorSpaceRef);
CGGradientRelease(gradient);

Animation not smooth problem

Why the animation of siri wave look so lag and not smooth?

Hardcoded value in (void)updateWithLevel:(CGFloat)level method.

When called with normalizedPowerLevelFromDecibels, the value are not being changed.

-(void)targetMethod:(NSTimer *)timer  {
    // NSLog(@"Siri Timer Called");
    PXSiriWave *siriWave = [timer userInfo];
    [siriWave updateWithLevel: [self _normalizedPowerLevelFromDecibels:self.averagePowerForChannel1]];
}

Corresponding library method has hardcoded value and level value is never used.

- (void)updateWithLevel:(CGFloat)level {
    CGFloat speed = 0.1;
    if (fabs(self.amplitude - _intensity) < speed) {
        self.amplitude = _intensity;
    } else {
        if (self.amplitude < _intensity) {
            self.amplitude += speed;
        } else {
            self.amplitude -= speed;
        }
    }
    
    [self setNeedsDisplay];
}