Comments (11)
We will need to look for : or =, with optional space before =.
Oh, of course! Sorry about that. Will fix it right away.
Or do you plan to deeply bake in the reliance on #+identifier / identifier: / identifier = matches?
I think this is open to discussion, given that we still are at the point where we can make breaking changes.
from denote.
The "^\\(#\\+\\)?\\(identifier\\)\\([\s\t]+\\)?[:=]\\([\s\t]+?\\)?\"?\\([0-9T]+\\)\"?"
matches all of the following with M-x re-builder
. Is there some other permutation we need to consider?
identifier = "20220611T114910"
identifier= 20220611T114910
identifier=20220611T114910
identifier= "20220611T114910"
identifier ="20220611T114910"
identifier : "20220611T114910"
identifier: 20220611T114910
identifier:20220611T114910
identifier: "20220611T114910"
identifier :"20220611T114910"
from denote.
Is there some other permutation we need to consider?
Nope this covers (more than) everything!
(more than): Few illegal cases like identifier= 20220611T114910
and identifier=20220611T114910
too. But that's OK.
Regexp suggestion:
"\\bidentifier\\s-*[:=]\\s-*\"?\\([0-9T]+\\)"
from denote.
Regexp suggestion:
Vastly superior! Thanks!
I guess now we need to abstract the "indentifier" part, right? That gives the user maximum flexibility.
from denote.
Suggestion 2:
"^.?.?\\b\\(identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\([0-9T]+\\)"
from denote.
I think ^.?.?\\b
will be good enough to avoid any false matches.
from denote.
Very wel!! Since you wrote it, do you want to submit a PR (or send a patch)? If you are on mobile, I can commit with you as the author (if you want).
from denote.
I haven't tested it properly and won't have time to do so until tonight (~10 hrs from now).
But I can create a PR and let you decide. If the PR is still open after I am done testing, and I need to update it, I'll do so, else will create another PR
from denote.
Okay, thank you! Will wait then.
from denote.
Closing this as it was fixed by #11.
from denote.
Thank you!
from denote.
Related Issues (20)
- parenthesis are stripped from the title including thier content when creating file name HOT 1
- How to stop denote-dired-rename-marked-files from prompting for pdf files? HOT 3
- The denote-find-link is the new name of denote-link-find-file, as part of 2.0.0-dev.] HOT 2
- A link to a certain part inside notes? HOT 9
- "denote-rename-buffer-mode" not effective when the note is called from register. HOT 4
- spaced repetition HOT 1
- Rename current file HOT 7
- Speed up the process of selecting a subdirectory with denote-subdirectory HOT 2
- wrong-type-argument error if denote--file-history is empty HOT 1
- Add Signature to the Link Description HOT 5
- Separate identifier format for journal entries HOT 5
- Linking machinery does not work anymore, configuration was unchanged HOT 13
- Request for Adding a Functionality Similar to ':if-new' Keyword in org-roam Capture Templates HOT 1
- Journal template HOT 1
- Executing `denote-keyword-add` on an encrypted file only keeps the .gpg extension HOT 15
- Error when setting `denote-journal-extras-title-format` to nil HOT 7
- denote-open-or-create not work when not run under denote-directory HOT 3
- `denote-keywords-{add,remove}` support for non-notes with conforming names please? HOT 4
- Return new path from `denote-rename-file` please? HOT 4
- Keywords with hyphens get squeezed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from denote.