prontolabs / pronto-haml Goto Github PK

Hello,

haml-lint is now at version 0.7.0 but pronto-haml require 'haml-lint', '> 0.6.0', '>= 0.6.0'
Is it possible to remove '> 0.6.0' from pronto-haml.gemspec to get the latest version of haml-lint working ?
What is the problem with the newer version of haml-lint ?

Hey,

We are using pronto to run rubocop, haml on our PRs. What we have recently noticed that pronto-haml didn't catch syntax error exception while pure haml-lint did.

We executed rubocop -a on multiple files and few haml files were updated with the following:

-#modal-window.modal.fade{"aria-hidden" => "true", "data-backdrop" => "static", "aria-labelledby" => "myModalLabel", "role" => "dialog"}
+# modal-window.modal.fade{"aria-hidden" => "true", "data-backdrop" => "static", "aria-labelledby" => "myModalLabel", "role" => "dialog"}

It's an obvious syntax error from haml.

$ git show --name-only | grep 'haml' | xargs haml-lint
_edit_page_block_modal.html.haml:0 [E] Syntax: Illegal element: classes and ids must have values.
_edit_cart_item_modal.html.haml:0 [E] Syntax: Illegal element: classes and ids must have values.

2 files inspected, 2 lints detected

But pronto run did not catch those syntax issues. A bug or some configuration issue?

Thanks!

Currently, the rubocop dependency is fixed to < 1.0. but rubocop 1 is released, with current version 1.18.0

The limitation on RuboCop < 1.0 just added and the lack of any real commits in a long time suggest this isn't being maintained. Is it significant work to update this for current RuboCop?