The pronamic-cli from pronamic

Array to string conversion in `VersionCommand`

I stumbled upon this error today:

Warning: Array to string conversion in /vendor/pronamic/pronamic-cli/src/VersionCommand.php on line 356

Lines 347 to 357 in f3ade4d

    
           $changelog_entry = $changelog->new_entry( $new_version ); 
        
           $changelog_entry->url = $url_repository; 
        
           $changelog_entry->version_previous = $version; 
        
           $changelog_entry->body .= $this->add_git_log( $cwd, $version, $output, $url_repository ); 
        
           if ( isset( $composer_json ) ) { 
        
           	$changelog_entry->body .= $this->generate_composer_json_changelog( $cwd, $version, $output ); 
        
           }

pronamic-cli/src/VersionCommand.php

Lines 1066 to 1072 in f3ade4d

    
           if ( ! is_object( $composer_json_old ) ) { 
        
           	return []; 
        
           } 
        
           if ( ! is_object( $composer_json_new ) ) { 
        
           	return []; 
        
           }

Add support for a `.wordpress-org` folder?

https://github.com/woocommerce/woocommerce/tree/master/.wordpress-org

Add feature to convert `CHANGELOG.md` to WordPress `readme.txt` changelog

As for your changelog, we recommend keeping the current release in the readme and splitting the rest out out into it’s own file — changelog.txt for example. By storing all the older changelog data there, you keep your readme small and allow the people who get really into long changelogs to read things on their own.

https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/

https://plugins.trac.wordpress.org/browser/akismet/trunk/readme.txt

Display GitHub tags link in `check_git_tagnames` function

https://github.com/pronamic/wp-deployer/blob/778fa74c200fd5d9d6d34dabd2b83af593ddbd29/src/VersionCommand.php#L815-L828

It would be handy to display a link to for example at this point.
https://github.com/pronamic/wp-datetime/tags

Users can verify the tags on GitHub.

Ideas for `version` command

Errors with no `CHANGELOG.md` file

PHP Warning:  Undefined variable $changelog_entry in /Users/remco/Projects/easycruit/vendor/pronamic/wp-deployer/src/VersionCommand.php on line 602

Warning: Undefined variable $changelog_entry in /Users/remco/Projects/easycruit/vendor/pronamic/wp-deployer/src/VersionCommand.php on line 602
PHP Warning:  Attempt to read property "body" on null in /Users/remco/Projects/easycruit/vendor/pronamic/wp-deployer/src/VersionCommand.php on line 602

Warning: Attempt to read property "body" on null in /Users/remco/Projects/easycruit/vendor/pronamic/wp-deployer/src/VersionCommand.php on line 602
https://github.com/pronamic/wp-easycruit/releases/tag/v2.1.0

Timeout i18n text domain fixer tool

The process "vendor/bin/pronamic release-to-wp-org" exceeded the timeout of 300 seconds

The process "vendor/bin/pronamic release-to-wp-org" exceeded the timeout of 300 seconds

Explain how the `version` command works

The version command does several things, but this is not immediately clear to users beforehand.

git pull
Working tree status (git status)
git branch --show-current
Check tagnames without v prefix.'
Run Composer script preversion
Check composer.json type property.
Check composer outdated
Check non-comparable Composer package versions (dev-*)
Check package.json version property
Check WordPress plugin file headers from *.php files
Check multiple WordPress plugins in working directory
Ask user for bump method (patch, minor, major)
Compose changelog
Set plugin file header version
Set theme style.css header version
Set Stable tag in readme.txt header
Set version in package.json
Run Composer script version
Git commit changes (git commit)
Git tag (git tag)
Git push (git push)
Run Composer script postversion

Exclude build directory by default in `wp-build`

pronamic-cli/src/WpBuildCommand.php

Lines 98 to 126 in 4228737

    
           // Build - Sync. 
        
           $io->section( 'Rsync' ); 
        
           $io->text( 'The build command uses <fg=green>rsync</fg=green> to copy files from the working directory to the build directory.' ); 
        
           $options = [ 
        
           	'--recursive', 
        
           	'--delete', 
        
           	'--verbose', 
        
           	'--exclude-from=' . $exclude_file, 
        
           ]; 
        
           if ( \is_readable( $working_dir . '/.pronamic-build-ignore' ) ) { 
        
           	$options[] = '--exclude-from=' . Path::makeRelative( 
        
           		$working_dir . '/.pronamic-build-ignore', 
        
           		getcwd() 
        
           	); 
        
           } 
        
           $command = [ 
        
           	'rsync', 
        
           	...$options, 
        
           	$working_dir . '/', 
        
           	$build_dir . '/', 
        
           ]; 
        
           $process = new Process( $command ); 
        
           $helper->mustRun( $output, $process );

Theme release currently not possible

pronamic-cli/src/ReleaseCommand.php

Line 158 in 15cb5e7

$gcloud_bucket_name = "gs://downloads.pronamic.eu/plugins/$slug";

pronamic-cli/src/ReleaseCommand.php

Line 198 in 15cb5e7

    
           'https://wp.pronamic.directory/wp-json/pronamic-wp-extensions/v1/plugins/' . $slug,

Add notice/warning about WP-CLI in `wp-build`

pronamic-cli/src/WpBuildCommand.php

Line 181 in 4228737

if ( file_exists( $bin_wp ) ) {

pronamic-cli/src/WpBuildCommand.php

Line 203 in 4228737

if ( file_exists( $bin_wp ) ) {

Add "generate release notes" class/function/command

Currently we generate the release notes quite late in the version command:

The version command does several things, but this is not immediately clear to users beforehand.

git pull

Working tree status (git status)

git branch --show-current

Check tagnames without v prefix.'

Run Composer script preversion

Check composer.json type property.

Check composer outdated

Check non-comparable Composer package versions (dev-*)

Check package.json version property

Check WordPress plugin file headers from *.php files

Check multiple WordPress plugins in working directory

Ask user for bump method (patch, minor, major)

Compose changelog

Set plugin file header version

Set theme style.css header version

Set Stable tag in readme.txt header

Set version in package.json

Run Composer script version

Git commit changes (git commit)

Git tag (git tag)

Git push (git push)

Run Composer script postversion

#10

pronamic-cli/src/VersionCommand.php

Lines 319 to 393 in 33351cf

    
           		/** 
        
           		 * If CHANGELOG.md check if new version is part of it? 
        
           		 */ 
        
           		$file_changelog_md = $cwd . '/CHANGELOG.md'; 
        
           		if ( ! is_readable( $file_changelog_md ) ) { 
        
           			$io->note( 'It is a good idea to keep track of the changes in a `CHANGELOG.md` file: https://keepachangelog.com/.' ); 
        
           		} 
        
           		if ( is_readable( $file_changelog_md ) ) { 
        
           			/** 
        
           			 * Remote URL. 
        
           			 *  
        
           			 * @link https://github.com/cookpete/auto-changelog/blob/0991f17ce936a9db490e2ad1a04121755038b78d/src/remote.js 
        
           			 */ 
        
           			$process = $this->new_process( 'git remote get-url origin', $cwd ); 
        
           			$process_helper->mustRun( $output, $process ); 
        
           			$url = $process->getOutput(); 
        
           			$components = $this->parse_git_url( $url ); 
        
           			$url_repository = 'https://' . $components['host'] . '/' . $components['organisation'] . '/' . $components['repository']; 
        
           			$changelog = new Changelog( $file_changelog_md ); 
        
           			if ( ! $changelog->has_entry( $new_version ) ) { 
        
           				$changelog_entry = $changelog->new_entry( $new_version ); 
        
           				$changelog_entry->url = $url_repository; 
        
           				$changelog_entry->version_previous = $version; 
        
           				$changelog_entry->body .= $this->add_git_log( $cwd, $version, $output, $url_repository ); 
        
           				if ( isset( $composer_json ) ) { 
        
           					$changelog_entry->body .= $this->generate_composer_json_changelog( $cwd, $version, $output ); 
        
           				} 
        
           				$choice    = ''; 
        
           				$iteration = 0; 
        
           				while ( 'ok' !== $choice ) { 
        
           					$iteration++; 
        
           					$io->title( 'Changelog' ); 
        
           					$io->text( $changelog_entry->body ); 
        
           					$choice = $io->choice( 
        
           						'🔁 ' . $iteration . ': Is the above changelog OK?', 
        
           						[ 
        
           							'ok', 
        
           							'subl', 
        
           						], 
        
           						'subl'  
        
           					); 
        
           					if ( 'subl' === $choice ) { 
        
           						$process = $this->new_process( 'subl -', $cwd, null, $changelog_entry->body ); 
        
           						$process_helper->mustRun( $output, $process ); 
        
           						$changelog_entry->body = $process->getOutput(); 
        
           					} 
        
           				} 
        
           				$changelog_entry_string = trim( $changelog_entry->render() ) . "\n\n"; 
        
           				$changelog->insert( $changelog->get_insert_position(), $changelog_entry_string ); 
        
           				$changelog->save(); 
        
           			} 
        
           		}

It would be more convenient if we could generate and display the changelog before the "Ask user for bump method". Based on the generated changelog, a user can more easily choose the desired bump method.

WordPress.org release command trunk OLD stable version

https://developer.wordpress.org/plugins/wordpress-org/how-to-use-subversion/#create-tags-from-trunk

If you use trunk properly, then we can easily compare your code changes without having to download two versions and running a tool.

Basically you should always:

Push to trunk with OLD stable version listed.

When code is good, update stable version and copy trunk to tag

🍻

https://wordpress.slack.com/archives/C1LBM36LC/p1680193618619809

	$changelog_entry = $changelog->new_entry( $new_version );

	$changelog_entry->url = $url_repository;

	$changelog_entry->version_previous = $version;

	$changelog_entry->body .= $this->add_git_log( $cwd, $version, $output, $url_repository );

	if ( isset( $composer_json ) ) {
	$changelog_entry->body .= $this->generate_composer_json_changelog( $cwd, $version, $output );
	}

	if ( ! is_object( $composer_json_old ) ) {
	return [];
	}

	if ( ! is_object( $composer_json_new ) ) {
	return [];
	}

	// Build - Sync.
	$io->section( 'Rsync' );

	$io->text( 'The build command uses <fg=green>rsync</fg=green> to copy files from the working directory to the build directory.' );

	$options = [
	'--recursive',
	'--delete',
	'--verbose',
	'--exclude-from=' . $exclude_file,
	];

	if ( \is_readable( $working_dir . '/.pronamic-build-ignore' ) ) {
	$options[] = '--exclude-from=' . Path::makeRelative(
	$working_dir . '/.pronamic-build-ignore',
	getcwd()
	);
	}

	$command = [
	'rsync',
	...$options,
	$working_dir . '/',
	$build_dir . '/',
	];

	$process = new Process( $command );

	$helper->mustRun( $output, $process );

	/**
	* If CHANGELOG.md check if new version is part of it?
	*/
	$file_changelog_md = $cwd . '/CHANGELOG.md';

	if ( ! is_readable( $file_changelog_md ) ) {
	$io->note( 'It is a good idea to keep track of the changes in a `CHANGELOG.md` file: https://keepachangelog.com/.' );
	}

	if ( is_readable( $file_changelog_md ) ) {
	/**
	* Remote URL.
	*
	* @link https://github.com/cookpete/auto-changelog/blob/0991f17ce936a9db490e2ad1a04121755038b78d/src/remote.js
	*/
	$process = $this->new_process( 'git remote get-url origin', $cwd );

	$process_helper->mustRun( $output, $process );

	$url = $process->getOutput();

	$components = $this->parse_git_url( $url );

	$url_repository = 'https://' . $components['host'] . '/' . $components['organisation'] . '/' . $components['repository'];

	$changelog = new Changelog( $file_changelog_md );

	if ( ! $changelog->has_entry( $new_version ) ) {
	$changelog_entry = $changelog->new_entry( $new_version );

	$changelog_entry->url = $url_repository;

	$changelog_entry->version_previous = $version;

	$changelog_entry->body .= $this->add_git_log( $cwd, $version, $output, $url_repository );

	if ( isset( $composer_json ) ) {
	$changelog_entry->body .= $this->generate_composer_json_changelog( $cwd, $version, $output );
	}

	$choice = '';
	$iteration = 0;

	while ( 'ok' !== $choice ) {
	$iteration++;

	$io->title( 'Changelog' );

	$io->text( $changelog_entry->body );

	$choice = $io->choice(
	'🔁 ' . $iteration . ': Is the above changelog OK?',
	[
	'ok',
	'subl',
	],
	'subl'
	);

	if ( 'subl' === $choice ) {
	$process = $this->new_process( 'subl -', $cwd, null, $changelog_entry->body );

	$process_helper->mustRun( $output, $process );

	$changelog_entry->body = $process->getOutput();
	}
	}

	$changelog_entry_string = trim( $changelog_entry->render() ) . "\n\n";

	$changelog->insert( $changelog->get_insert_position(), $changelog_entry_string );

	$changelog->save();
	}
	}

pronamic / pronamic-cli Goto Github PK

pronamic-cli's People

Contributors

Stargazers

Watchers

pronamic-cli's Issues

Recommend Projects

Recommend Topics

Recommend Org