/metrics returning JSON about client_ruby

[deepthawtz]

maybe this is OK (Prometheus can ingest this JSON) but confused me because in a bare Rack app /metrics is returned in plain text.

[grobie]

@deepthawtz Which client version do you use? JSON support has been removed in v0.5.0 https://github.com/prometheus/client_ruby/releases/tag/v0.5.0

[grobie]

Text format was added in v0.3.0, so you seem to use a version between v0.3.0 and v0.5.0. The server uses HTTP content negotiation and will prefer text over json. The Prometheus server >= v1.0.0 doesn't support JSON anymore.

I strongly suggest to update your client library version, also have a look at the README. It's recommended to add a Gzip middleware as described there.

[deepthawtz]

in my Gemfile.lock I see prometheus-client (0.6.0)

[deepthawtz]

steps to reproduce:

1. rails new poo
2. add gem 'prometheus-client' to Gemfile && bundle install
3. update config/application.rb and add

require "prometheus/client/rack/collector"
require "prometheus/client/rack/exporter"
# ... in Rails::Application configuration
   config.middleware.use Prometheus::Client::Rack::Collector
   config.middleware.use Prometheus::Client::Rack::Exporter

[deepthawtz]

ah... basically won't work w/o Rack::Deflater I see now.. thanks

[grobie]

@deepthawtz What? How's that possible, the code path to respond with JSON is not longer available in v0.6.0. Can you double check that you don't have an older gem version installed and that your server really uses 0.6.0? Maybe log the client version puts Prometheus::Client::VERSION.

Please re-open if you see a 0.6.0 client responding with JSON format.

[deepthawtz]

odd. I see:

uninitialized constant Prometheus::Client::VERSION (NameError)

but

gem list | grep prometheus
prometheus-client (0.6.0)

no other versions are installed

and the prometheus-client code on disk definitely has lib/prometheus/client/version.rb with VERSION set to 0.6.0

still digging...

[grobie]

You might need to require the file first:

require 'prometheus/client/version'; puts Prometheus::Client::VERSION

On Wed, Aug 31, 2016 at 12:22 PM Dylan Clendenin [email protected]
wrote:

odd. I see:

uninitialized constant Prometheus::Client::VERSION (NameError)

but

gem list | grep prometheus
prometheus-client (0.6.0)

no other versions are installed

and the prometheus-client code on disk definitely has
lib/prometheus/client/version.rb

still digging...

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#30 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAANaBAKE0qW6RkpQBcvskry42WSi177ks5qlapCgaJpZM4Jxs2r
.