Coder Social home page Coder Social logo

Comments (1)

Sinjo avatar Sinjo commented on June 11, 2024

Hi @rquinlivan 👋🏻

The collector middleware we provide in Prometheus::Middleware::Collector is intended to cater to basic HTTP metric collection needs and doesn't allow customising path filtering or metric labels.

Back when we were preparing for our 1.0 release, we did consider adding some extra options to initialize, to allow customising labels and path handling by passing lambdas to it which would override our default implementations. We quickly realised that once we did that, there was essentially nothing left of our middleware code and it was just invoking lambdas. At that point, we didn't feel that there was any value in using our middleware and it would be better for users of client_ruby to create their own collector middleware in their application's codebase (possibly copying ours as a base).

If you're interested, the original discussion is over at #111 and references the implementation that we scrapped.

Hope that's helpful!

from client_ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.