promact / oauth-server

OAuth server to authenticate logins for different promact in house applications.

Build Status

Travis	Appveyor	Server side coverage	Client side coverage

promact-oauth-server

OAuth server to authenticate logins for different promact in house applications.

oauth-server's Issues

Upgrade to latest Angular 2.0 release version

Update project to target latest AngularJS 2.0 version. identify changes in code and list out here. we will assign work to respective members accordingly.

build issue after resend email functionality was merged in dev

After pull request #61 was accepted, Typescript build is not working. Here is the log of compiling tsc-p tsconfig.json

../../../../../../AppData/Roaming/npm/node_modules/typescript/lib/lib.es6.d.ts(4133,14): error TS2300: Duplicate identifier 'PropertyKey'.
typings/globals/core-js/index.d.ts(3,14): error TS2300: Duplicate identifier 'PropertyKey'.
typings/globals/core-js/index.d.ts(67,5): error TS2687: All declarations of 'name' must have identical modifiers.
typings/globals/core-js/index.d.ts(127,5): error TS2403: Subsequent variable declarations must have the same type. Variable '[Symbol.unscopables]' must be of type '{ copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: ...', but here has type 'any'.
typings/globals/core-js/index.d.ts(244,5): error TS2687: All declarations of 'flags' must have identical modifiers.
typings/globals/core-js/index.d.ts(258,5): error TS2687: All declarations of 'EPSILON' must have identical modifiers.
typings/globals/core-js/index.d.ts(293,5): error TS2687: All declarations of 'MAX_SAFE_INTEGER' must have identical modifiers.
typings/globals/core-js/index.d.ts(300,5): error TS2687: All declarations of 'MIN_SAFE_INTEGER' must have identical modifiers.
typings/globals/core-js/index.d.ts(439,5): error TS2403: Subsequent variable declarations must have the same type. Variable '[Symbol.toStringTag]' must be of type '"Symbol"', but here has type 'string'.
typings/globals/core-js/index.d.ts(439,5): error TS2687: All declarations of '[Symbol.toStringTag]' must have identical modifiers.
typings/globals/core-js/index.d.ts(446,5): error TS2687: All declarations of 'prototype' must have identical modifiers.
typings/globals/core-js/index.d.ts(474,5): error TS2687: All declarations of 'hasInstance' must have identical modifiers.
typings/globals/core-js/index.d.ts(480,5): error TS2687: All declarations of 'isConcatSpreadable' must have identical modifiers.
typings/globals/core-js/index.d.ts(486,5): error TS2687: All declarations of 'iterator' must have identical modifiers.
typings/globals/core-js/index.d.ts(492,5): error TS2687: All declarations of 'match' must have identical modifiers.
typings/globals/core-js/index.d.ts(498,5): error TS2687: All declarations of 'replace' must have identical modifiers.
typings/globals/core-js/index.d.ts(504,5): error TS2687: All declarations of 'search' must have identical modifiers.
typings/globals/core-js/index.d.ts(510,5): error TS2687: All declarations of 'species' must have identical modifiers.
typings/globals/core-js/index.d.ts(516,5): error TS2687: All declarations of 'split' must have identical modifiers.
typings/globals/core-js/index.d.ts(522,5): error TS2687: All declarations of 'toPrimitive' must have identical modifiers.
typings/globals/core-js/index.d.ts(528,5): error TS2687: All declarations of 'toStringTag' must have identical modifiers.
typings/globals/core-js/index.d.ts(534,5): error TS2687: All declarations of 'unscopables' must have identical modifiers.
typings/globals/core-js/index.d.ts(591,5): error TS2403: Subsequent variable declarations must have the same type. Variable '[Symbol.toStringTag]' must be of type '"Math"', but here has type 'string'.
typings/globals/core-js/index.d.ts(591,5): error TS2687: All declarations of '[Symbol.toStringTag]' must have identical modifiers.
typings/globals/core-js/index.d.ts(595,5): error TS2403: Subsequent variable declarations must have the same type. Variable '[Symbol.toStringTag]' must be of type '"JSON"', but here has type 'string'.
typings/globals/core-js/index.d.ts(595,5): error TS2687: All declarations of '[Symbol.toStringTag]' must have identical modifiers.
typings/globals/core-js/index.d.ts(610,5): error TS2687: All declarations of 'size' must have identical modifiers.
typings/globals/core-js/index.d.ts(616,5): error TS2687: All declarations of 'prototype' must have identical modifiers.
typings/globals/core-js/index.d.ts(627,5): error TS2687: All declarations of 'size' must have identical modifiers.
typings/globals/core-js/index.d.ts(633,5): error TS2687: All declarations of 'prototype' must have identical modifiers.
typings/globals/core-js/index.d.ts(648,5): error TS2687: All declarations of 'prototype' must have identical modifiers.
typings/globals/core-js/index.d.ts(662,5): error TS2687: All declarations of 'prototype' must have identical modifiers.
typings/globals/core-js/index.d.ts(674,5): error TS2687: All declarations of 'value' must have identical modifiers.
typings/globals/core-js/index.d.ts(786,5): error TS2687: All declarations of 'prototype' must have identical modifiers.

Email Sending Not Working In Live

Issue In Email Send Method

Update test cases as per angular 2.0.0

You need to update your all test cases and mock files as per required in angular 2.0.0

When we click on "Details" page we can see "Edit" button.

@ankit213

Steps to be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on User Tab.
3. Then click on Details button you may see the Edit Button for 2 or 3 seconds and then it disappears after it.

Please see the video which is been sent to you personally on slack.

In "Consumer App" Submit button is not clickable and no Error message also.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on Consumer App.
3. Click on Add a New App.
4. Do not enter any details just click on submit button.
5. The button is not clickable.
6. We are not able to find out the error messages also.
7. Do it same as User and Project.

Updated md2-select and md2-multiselect

Updated md2-select and md2-multiselect on Oauth server

project management - to manage projects and add employees project mapping

Project Management

Allow SSL settings in Mail

right now mail settings are hard coded with no security. I want ability to set the whether I want security or not. Please make appropriate changes.

change npm to yarn

yarn is much faster in deployment scenarios. It needs to be updated.

add gulp task to run client side unit test on travis ci

Create a gulp task like 'test-ci' which should execute test cases in a CI environment with travis as reporter.

Do not copy .js.map file while in production in gulp task

right now it copies all js and js.map file in lib folder. It should just only copy .js file to lib for the Production environment. For development it can copy js.map.

In "Add Projects" toaster message is wrong.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on Projects tab.
3. Click on "Add Projects"
4. I am not entering any details.
5. Then click on Add New Projects, We may see the toaster message as "Project and SlackChannel Name already exists"
6. Change the toaster message.

Please see the screenshot.

Do not use any static class or methods unless required absolutely

Do not use any static class or methods unless required absolutely. Using static class creates an issue for Unit testing. So, String constants, environment variables and any other equivalent utility classes should also be not static.

creating consumer apps to validate consumers who can access to the system

Time is not in proper format and Title "Time" is missing.

@iamronakshah

Steps to be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on Projects tab.
3. Then you may see the added projects in that date and time is not in proper format and even the time is been missing from the title.

Please see the screenshot.

https://promactslack.azurewebsites.net/ is not working.

@iamronakshah

Steps to be followed:

1. Open a link (https://promactslack.azurewebsites.net/)
2. Then click on login with promact.
3. Then you may see the page is loading when you console you may see the error.

Please refer the screenshot.

In "Add Consumer" there is no back button.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on Consumer App tab.
3. Click on "Add a New App".
4. There is no back button on the top right-hand

Please refer the screenshot:

side.

"Add User" Toaster message is wrong.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Then click on Add Button.
4. The toaster message on the top right-hand side says "Slack User Name Already Exists"

Please refer the screenshot.

Pagination is required in Users Tab.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. You may see the list goes on, So for that we can add an pagination so it will be easy to scroll the pages.

Design - Alignment is not proper in various pages.

@Asrapromact

Steps to be followed:

Scenario 1:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Click on Edit User.
4. Then you may see the title and the button is not aligned properly.
5. I have attached the last screenshot like that it must look.

The various pages are:

A) Edit User.
B) Add User.
C) Add Project.
D) Edit Project.
E) User detail page.
F) Add Consumer App.
G) Login Page.

Scenario 2:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. You may see the Action column.
4. All the 3 buttons are not proper.

The various pages are:

A) User.
B) Project.

Scenario 3:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Click on Add User.
4. Click on email field and do not enter anything, Then you may see an error and you may notice that alignment is not proper.

Scenario 4:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on User tab
3. Click on Edit User.
4. You may see the Slack Username line is small and other lines are big, So change according to it.

Scenario 5:

Login page of the link is not properly designed.

Please refer the screenshot.

user's registration by admin to use oauth server system

User Registration Feature Flow

extra text appearing on top of the page

asp-fallback-href="~/lib/bootstrap/dist/css/bootstrap.min.css" asp-fallback-test-class="sr-only" asp-fallback-test-property="position" asp-fallback-test-value="absolute" />

this extra text is appearing on login page

https://promactoauth.azurewebsites.net/Login

In "View Project" list of team members are not fully seen.

@iamronakshah

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on Project tab.
3. Click on View Project.
4. In List of Team Members you are able to see only 3 names as there are 6 team members, rest of the team members are not seen.

Please see the screenshot.

In "User Edit" page back button is not proper.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Click on Edit button on anyone of the user.
4. Then you may see back button it is not same as others page.

Please refer screenshot.

List of Team Members and Team Leader are not in alphabetical order.

@iamronakshah

Steps tp be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on Project tab.
3. Click on Add Project.
4. When you select "List of Team Members" and "List of Team Leader", you may see they are not arranged in alphabetical order.

Please see the screenshot.

Update Consumer Module Related Test Cases

Separate All Module And Solve Routing Issue

Separated out modules of the project like Consumer app, user , project, change password and solved routing issue with Ronak's help.

Allow re-sending of password for a user by admin

Allow admin to resend credential email again. It is possible at many times email may not have been sent.

Solved Material Related issue

Anguler 2.0.0 not find Material related file ,so analysis about and check change log for rc-5 to Anguler 2.0.0

Loader Implement

Added Loader Service

Forgot Password In Promact.Oauth.Server Project

Implement Forgot Password Functionality via mail.

Tab Switching issues.

@iamronakshah

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Then click on various tabs continuously do it for 2 to 3 times then leave the mouse you may see the tab switching automatically.

Please see the video which I am sending you in slack personally.

add client side code coverage tool

integrate client side code coverage tool like Istanbul and link that with coveralls.

Create appsettings.development.example.json in project detailing all settings used in application

Create appsettings.development.example.json to provide a working example to the other developers how to create appsetting for development and production.

hard coded values of number of leaves

Values of Sick leave and casual leave is hard coded in the application. It should come from the database.

Implement Email sending using Web API of sendgrid

right now we are sending email using SMTP. We should implement Web API-based email sending provided by SendGrid. Keep both implementations as in local development environment we will send using SMTP on production we will use Web API.

https://www.nuget.org/packages/Sendgrid
https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/index.html

"Resend Mail" Functionality is not wroking.

Scenario 1:

Steps to be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Then Click on "Resend Mail" you may see the loader keeps on rotating and we get an error as an internal server.

Scenario 2:

Steps to be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Click on Add User enter all the details then click on add you may get the error.

Please refer the screenshot.

Implement NLog

Implement NLog in Oath Project using below link "https://docs.asp.net/en/latest/fundamentals/logging.html"

UserRepository Test Cases are not working properly in travis-ci environment

It's working on local properly but due to some reason not working on travis-ci enviorment

oauth server development to authenticate promact users to access promact's different applications

In "Add Projects" title is wrong.

@ankit213

Steps to be followed:

1. Open Promact Oauth link (https://promactoauth.azurewebsites.net)
2. Click on Project Tab.
3. Click on "Add Projects"
4. You can see the title as "USERS" it must be "PROJECTS"

Please see the screenshot for more reference.

In "User List" Register user are not in proper order.

@ankit213

Steps tp be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on user tab.
3. Click on Add User.
4. Enter all the details and click on add, You may see the added user will be seen in a random order so make it as new user will be seen at the top.

"Add User" Email field is not working properly.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Click on Add User.
4. Then Enter the details (Firstname, Lastname, Email and slack Username)
5. Then Click on Add button you may see "@promactinfo.com" is been added when you click on Add button.

Please refer the video which is been sent to you personally.

Change Password is not working.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on Change Password tab.
3. Enter the Old Password in Password.
4. Enter the same old password in "New Password" and in "Confirm Password" also.
5. Then click on change button. The password will be changed.

Please refer the video which I have sent you in slack personally.

"Add User" Functionality is not working.

@ankit213

Steps to be followed:

1. Open a live link (https://promactoauth.azurewebsites.net)
2. Click on User tab.
3. Click on Add User.
4. Enter the following details.
   A) First Name: qwerty
   B) Last Name: poiuy
   C) Email: vishal
   D) Slack Username: asdf
   E) User Role: Employee
   F) Date: 10/10/2016
5. Then click on Add button twice the User will be added successfully.
6. Already the Email has been register then also it is been saved.
7. The toaster message says User is been added successfully.

Please see the video which is been sent to you personally on slack.

Update publish settings to include template folder in publish

update publish settings to include template folder to be published.

Resolve Issue in obtaining SlackUserName after login

SlackUser is not available after users login through slack

In " Edit Projects" Users List is not been seen.

@ankit213

Steps to be followed:

1. Open a link (https://promactoauth.azurewebsites.net)
2. Click on Project tab.
3. Click on Edit in any one of the projects.
4. Users list is not been seen in the edit page.
5. If we want to delete or add any user then how come will we delete or add any user.

Please refer the screenshot.

Create SETUP.md file to list out all environment variables and appsettings

List out all environment and appsettings variable for setting up application on any new server.