projecteq / projecteqquests Goto Github PK

This function expects a maximum of 2 argument(s) but instead it is receiving 3.

Duplicate index 999999.

Server is getting (EntityList, double, double, double, SCALAR, int).

added to to the line to make sense

Original issue reported on code.google.com by [email protected] on 30 Dec 2011 at 11:54

Attachments:

• Crusader_Eaxl.pl.patch

As mentioned in #46:
Collier sits and stands as on live.
Collier rejects lower level chars from quest like live.
Collier rejects based on faction like live.

Have this issue

same as last

Original issue reported on code.google.com by [email protected] on 30 Dec 2011 at 11:55

Attachments:

• Crusader_Myxl.pl.patch

This can of course be tweaked to be more accurate, but shouldn't we do something like this to make life easier?

https://gist.github.com/xackery/937345680b8ddec277fb1f3cec00b77f

This function expects a maximum of 0 argument(s) but instead it is receiving 1.

https://github.com/ProjectEQ/projecteqquests/blob/f678149a12f6b6efbe3c44cbfe06e68c01b3fbfc/cazicthule/#a_Thul_Tae_Ew_High_Priest.lua#L28

So, this is more just an ordering warning, it seems:

my linter is thinking another file in the same path is taking priority on spawn_guard() <-- with no args, because spawn_guards(e) defined in this file is declared AFTER the function call.

I don't think quest api works this way, but figured i'd share the warning anyways.

This is remedied by shifting up the spawn_guards(e) function up a bit.

I rewrote the quest file so now it will no longer cause crashes and will loop wont let me drop a .pl file so ill just post the code.

function event_spawn(e)
eq.set_timer("spiders", 19000) -- Set the initial timer for spawning spiders with an 8-second delay
end

function event_timer(e)
local npc_list = eq.get_entity_list():GetNPCList() -- Get the list of NPCs in the zone
local spider_count = 0 -- Initialize spider count

if npc_list ~= nil then
    for npc in npc_list.entries do
        local npc_type_id = npc:GetNPCTypeID()
        if npc_type_id == 206000 or npc_type_id == 206001 or npc_type_id == 206002 or npc_type_id == 206086 or npc_type_id == 206071 or npc_type_id == 206070 or npc_type_id == 206072 or npc_type_id == 206069 then
            spider_count = spider_count + 1 -- Increment spider count
        end
    end
end

if spider_count < 400 then -- Check if the number of spiders is less than 400
    -- Spawn additional spiders until reaching 1,000,000, staggering by 8 seconds
    if spider_count < 400 then
        eq.spawn2(206000, 28, 0, 803, -285, 4.63, 314) -- Spawn a spider
        eq.spawn2(206001, 29, 0, 804, 285, 4.63, 314) -- Spawn a spider
        eq.spawn2(206002, 30, 0, 1443, 285, 4.63, 314) -- Spawn a spider
        eq.spawn2(206086, 31, 0, 1443, -285, 4.63, 314) -- Spawn a spider
        eq.spawn2(eq.ChooseRandom(206071, 206070), 26, 0, 1155, 605, 4.63, 0) -- Spawn a spider
        eq.spawn2(eq.ChooseRandom(206072, 206069), 24, 0, 1155, -600, 4.63, 0) -- Spawn a spider
        eq.set_timer("spiders", 19000) -- Reset the timer for the next spider spawn after 8 seconds
    end
else
    eq.stop_timer("spiders") -- Stop the timer if 400 spiders have been spawned
    eq.set_timer("spiders", 19000) -- Reset the timer to start over
end

end

Our lua code formatting is inconsistent.

I can run through a script to fix it for tab indentation or space indentation. Just tell me which :P

local miner628 = 0; is defined inside event_spawn

then referred to in another function:

will this cause the value to always be 0?

Or is scope not properly honored in quest API?

quests/pojustice/201438.lua:87: attempt to index field 'other' (a nil value)

If a character has say, 20 corpses on the server, and the character has a lot of items, there are countless queries against those corpses looking for the items in the above snippet.

This may be an actual bug with HasItem where it is looking at corpses for some reason but right now when a player enters the zone it can lead to a zone crash.

If someone has A LOT of corpses Client:HasItem will crash ... probably should just give up after a handful of corpses.

Note the uppercase _Spawn function ref here:

while function is is lowercase _spawn here:

This callback may never occur?

I don't run these zones on my server, but I do have custom quests on the original continent that use $npc->SaveGuardPosition(). I found they were no longer working today. After some digging, this commit 10 months ago changed the api,

EQEmu/Server@f76fffe

After looking into it, you guys still have these references that will no longer work. They need to be changed to pass $x, $y, $z, $h.

I will only post this as FYI - I don't run these quests here, and will not commit the mods that I have not tested here. I did make the change locallly to my custom stuff that uses this interface and they all resumed working after my fix.

These are what you still have, that I believe are broken:

./eastwastes/Boridain_Glacierbane.pl: $npc->SaveGuardSpot(0);
./eastwastes/ringfivecoord.pl: $mobnpc1->SaveGuardSpot(0);
./eastwastes/ringfivecoord.pl: $mobnpc2->SaveGuardSpot(0);
./eastwastes/ringfivecoord.pl: $mobnpc3->SaveGuardSpot(0);
./eastwastes/ringfivecoord.pl: $mobnpc4->SaveGuardSpot(0);
./eastwastes/ringfivecoord.pl: $mobnpc5->SaveGuardSpot(0);
./eastwastes/Tain_Hammerfrost.pl: $mobnpc1->SaveGuardSpot(0);
./eastwastes/Tain_Hammerfrost.pl: $mobnpc2->SaveGuardSpot(0);
./eastwastes/Tain_Hammerfrost.pl: $mobnpc3->SaveGuardSpot(0);
./eastwastes/Tain_Hammerfrost.pl: $mobnpc4->SaveGuardSpot(0);
./eastwastes/Tain_Hammerfrost.pl: $mobnpc5->SaveGuardSpot(0);
./fungusgrove/#Caller_Groo.pl: $npc->SaveGuardSpot(0);
./fungusgrove/#Caller_Murkin.pl: $npc->SaveGuardSpot(0);
./fungusgrove/#Caller_Torgal.pl: $npc->SaveGuardSpot(0);
./hollowshade/a_furious_owlbear.pl: $npc->SaveGuardSpot();
./hollowshade/a_grimling_invader.pl: $npc->SaveGuardSpot();
./hollowshade/a_sonic_wolf_fiend.pl: $npc->SaveGuardSpot();

By the way, I had no idea your server was running my implementation of the Hollowshade War - very cool!!

This call needs to be re-evaluated. In math.random(a, b), Lua will select a number from a up to b. If b is empty or lower than a, it will throw an error such as:
quests/lua_modules/npc_ext.lua:46: bad argument #2 to 'random' (interval is empty) from the logs on Discord

cc: @fryguy503

likely should be e.other

as i'm working on my metadata/quest parser fun, here's some interesting feedback/cleanup:

as a random one: npc Savil_Tranquilsong not found
if you query select id, name from npc_types where name like '%Tranquilsong%';
54070 Sarialiyn_Tranquilsong
no Savil, so butcher/Savil_Tranquilsong.pl might be orphaned

npc #a_corrupt_treant not found
npc #an_iksar_manslayer not found
npc #Animal_Trainer_Kayzlc not found
npc #Captain_Klunga not found
npc #Diablo_Xi_Va_Temariel not found
npc #Elder__Spirit_of_Wisdom not found
npc #Legionnarie_Marais not found
npc #Man`eating_Freshwater_Shark not found
npc #Mister_Lockout not found
npc #Raidman not found
npc #Translocator_Stumpeh not found
npc #Zeixshi`Kar_the_Ancient not found
npc a_banished_Kerran not found
npc a_Beggar not found
npc a_diseased_shark not found
npc a_heretic_prophet not found
npc a_heretic_prophet not found
npc A_Lictor_of_the_Heart not found
npc a_sarnak_champion not found
npc A_storm_portal_ not found
npc an_accursed_prisoner not found
npc Animal_Handler_Yluxx not found
npc Artisan_Bill_Whistletop_copy not found
npc Artisan_Calian_Silverlake not found
npc Artisan_Dosan_Vis`moor not found
npc Artisan_Elistar_Vorann not found
npc Artisan_Garth_Okken not found
npc Artisan_Gorion_Telld`Mare not found
npc Artisan_Kjell_Sunrunner not found
npc Artisan_Korzan_Virimove not found
npc Artisan_Nala_Goldenthorn not found
npc Artisan_Sieeva_Koan not found
npc Artisan_Srekta_Froreki not found
npc Artisan_Vidi_Cogsworthy not found
npc Artisan_Vuro_Padfoot not found
npc Artisan_Yar_Shiverbrow not found
npc default not found
npc default not found
npc default not found
npc default not found
npc Duggas_Helpyre not found
npc Ebenizer_Sprooket not found
npc Eternal_Animist_Ukki_ not found
npc Firin_McYorth not found
npc Forager_Grik not found
npc Forager_Grik not found
npc Geoard_Bluehawk not found
npc Granin_O'Gill not found
npc Hagbletha not found
npc Horgram not found
npc Imp`ossible not found
npc Initiate_Sirchthain not found
npc Khala_Dun_Ahjin not found
npc Khala_Dun_Aihjin not found
npc Khala_Dun_Bokh not found
npc Khala_Dun_Jasir not found
npc Khala_Dun_Koby not found
npc Khrixs_Abomination not found
npc Kimm_McShannel not found
npc Lossenmachar not found
npc Mathii_Fauris not found
npc Molon_T`Plth not found
npc Neysia_Morningbloom not found
npc Protector_of_the_ruins not found
npc Raotin_teawel not found
npc Raotin_teawel not found
npc Ratlan_Matrick not found
npc Savil_Tranquilsong not found
npc Severg_ODanos not found
npc Soulbinder_Zlippi not found
npc Tarakix_V`Rasym not found
npc The_Spirit_of_Rage not found
npc Ur`Koraag not found
npc Voknya not found
npc Warlord_Prolazz not found
npc Woodspirit_Trigger not found

shouldn't this line:

be

if(item_lib.check_turn_in(e.trade, {e.gold == 10})) then

Can we nuke this?

Currently when you hand in the Orc Thaumaturgists Spell Book to Yuin Starchser for the newbie caster staff quest there's a made up text:
e.self:Say("Excellent work, " .. e.other:GetName() .. ". Now I need you to gather a Pristine Forest Drakeling Scale and an Arborean Amber. Return this staff and the items I require and then I will create your new staff."); -- Text made up

According to Allakhazam (http://everquest.allakhazam.com/db/quest.html?quest=2043) the text should be..
e.self:Say("Well done young Art Keeper. Take this Rough Art Keepers Initiate Staff and go forth and gather a Pristine Forest Drakeling Scales and an Arborean Amber. When you have acquired those two items return them to me with the Rough Art Keepers Initiate Staff and I will put the final touches on the staff.");

This was lightly discussed in eqemu coders on discord, but basically.. each of these can be replaced from table.getn(var) to #var

etc..I'll do a PR real quick

• projecteqquests/inktuta/encounters/noqufiel.lua

  Line 156 in f678149

  current_hp=max_hp;

  Undefined global max_hp.

• projecteqquests/lavastorm/a_fire_goblin_scout.lua

  Line 4 in f678149

  if(eq.get_entity_list():IsMobSpawnedByNpcTypeID(scorchfist)==false) then

  Undefined global scorchfist.

• projecteqquests/misty/encounters/Misty.lua

  Line 501 in f678149

  e.self:ModifyNPCStat("min_hit", tostring(deputyold_min_hit));

  Undefined global deputyold_min_hit.

• projecteqquests/misty/encounters/Misty.lua

  Line 502 in f678149

  e.self:ModifyNPCStat("max_hit", tostring(deputyold_max_hit));

  Undefined global deputyold_max_hit.

• projecteqquests/misty/encounters/Misty.lua

  Line 522 in f678149

  e.self:ModifyNPCStat("min_hit", tostring(deputyold_min_hit));

  Undefined global deputyold_min_hit.

• projecteqquests/misty/encounters/Misty.lua

  Line 523 in f678149

  e.self:ModifyNPCStat("max_hit", tostring(deputyold_max_hit));

  Undefined global deputyold_max_hit.

• projecteqquests/poknowledge/Borik_Darkanvil.lua

  Line 26 in f678149

  if(item_lib.check_turn_in(e.trade, {item1 = 29230, item2 = 29229, item3 = 29228, platinum == 3000})) then

  Undefined global platinum. (should be e.platinum)

• projecteqquests/potimeb/zone_status.lua

  Line 661 in f678149

  expedition:AddLockout('Phase 6 Complete', 475200);

  Undefined global expedition. This one seems to be due to the fact that expedition is local scoped in event_spawn yet gets ref'd in event_timer.

• projecteqquests/qeynos2/Astaed_Wemor.lua

  Line 33 in f678149

  e.other:SummonItem(ChooseRandom(6022,6023,6024,6025)); -- Item(s): Bronze Warhammer (6022), Bronze Flail (6023), Bronze Morning Star (6024), Bronze Warclub (6025)

  Undefined global ChooseRandom.

• projecteqquests/qeynos2/Flynn_Merrington.lua

  Line 10 in f678149

  elseif(e.message:findi("gnoll loving weakling who isn't fit to comb my feet")and tax.tax_collection ~= nil) then

  Undefined global tax.

• projecteqquests/qeytoqrg/Baobob_Miller.lua

  Line 43 in f678149

  if(item_lib.check_turn_in(e.trade, {item1 = 13755, gold == 21})) then

  Undefined global gold.

• projecteqquests/qeytoqrg/Baobob_Miller.lua

  Line 53 in f678149

  elseif(item_lib.check_turn_in(e.trade, {item1 = 13754, gold == 15})) then

  Undefined global gold.

• projecteqquests/qeytoqrg/Baobob_Miller.lua

  Line 63 in f678149

  elseif(item_lib.check_turn_in(e.trade, {item1 = 13753, gold == 5})) then

  Undefined global gold.

• projecteqquests/qeytoqrg/Chanda_Miller.lua

  Line 44 in f678149

  if(item_lib.check_turn_in(e.trade, {item1 = 13752, gold == 21})) then

  Undefined global gold.

• projecteqquests/qeytoqrg/Chanda_Miller.lua

  Line 54 in f678149

  elseif(item_lib.check_turn_in(e.trade, {item1 = 13751, gold == 15})) then

  Undefined global gold.

• projecteqquests/qeytoqrg/Chanda_Miller.lua

  Line 64 in f678149

  elseif(item_lib.check_turn_in(e.trade, {item1 = 13750, gold == 5})) then

  Undefined global gold.

• projecteqquests/qeytoqrg/Mira_Sayer.lua

  Line 9 in f678149

  elseif(e.message:findi("crying")and tax.tax_collection ~= nil) then

  Undefined global tax.

• projecteqquests/rivervale/Blinza_Toepopal.lua

  Line 7 in f678149

  if(timer == jillin) then

  Undefined global timer. Undefined global jillin.

• projecteqquests/rivervale/Daleen_Leafsway.lua

  Line 18 in f678149

  if (timer == blurt) then

  Undefined global timer. Undefined global blurt.

• projecteqquests/rivervale/Fiddy_Bobick.lua

  Line 9 in f678149

  if(wp == 6) then

  Undefined global wp.

• projecteqquests/rivervale/Gaffin_Deeppockets.lua

  Line 6 in f678149

  if(timer == lenny) then

  Undefined global timer. Undefined global lenny.

• projecteqquests/freporte/Brunar_Rankin.lua

  Line 18 in f678149

  item_lib.return_items(e.self, e.other, e.trade);

  Undefined global item_lib.

• projecteqquests/poknowledge/Vivian_the_True.lua

  Line 26 in f678149

  item_lib.return_items(e.self, e.other, e.trade)

  Undefined global item_lib.

• projecteqquests/tutorialb/Frizznik_Hailstorm.lua

  Line 35 in f678149

  item_lib.return_items(e.self, e.other, e.trade);

  Undefined global item_lib.

I am not comfortable proposing commits yet but propose this one if any one cares to look
I had troubles with this and just saw someone on discus with the same problem with updates on NOT 3306

PLUGINS : FILE : MySQL.pl
line 25
add /insert : $port = $config->{"server"}{"database"}{"port"};

line 31
change : $dsn = "dbi:mysql:$db:$host:3306";
to : $dsn = "dbi:mysql:$db:$host:$port";

then ( and i have not looked at it yet ) the install script install.sh and/or eqemu_server.pl should prompt for a port on first run if eqemu_config.json does not exist or the port is not defined in the config file and default to 3306 if non entered.

EXAMPLE eqemu_config.json section :

"database": {
"db": "eqworld1",
"host": "127.0.0.1",
"password": "SUPE-SECRET",
"port": "3853", ********* NOT 3306 *********
"username": "EqDbAdmin"

Currently you can't ask Terran Starwatcher in Felwithe about the cleric newbie weapon quest.

The chat link to ask about it is [further guidance] which is currently further down the else if chain than just [guidance] (which is his general intro) in his lua file.

The further guidance bit needs to be moved to the top of the file or you end up only getting his intro.

Hello, just doing the warrior pike quest in east Cabilis. The footman pike quest has a hot text of "assist Warlord Hikyg" in the quest file it is "assist Warlord Kikyg" Here is the Alla link for reference: https://everquest.allakhazam.com/db/quest.html?quest=233

Function above calls a commented out function War_Combat

added to to the line to make sense

Original issue reported on code.google.com by [email protected] on 30 Dec 2011 at 11:54

Attachments:

• Crusader_Eaxl.pl.patch