Comments (5)
If I add it to the tests, I would repeat it's value. I have changed it to package private, since the tests use the same package.
from iris-java.
Not really, because the encoding of the data blobs are completely irrelevant from Iris's point of view and are independent of the strings. In essence, the encoding used within the protocol and the encoding in the tests are semantically different things.
But package private will do just fine.
from iris-java.
I can't rebuild the original String, if I don't know the original encoding.
But you're right, since I can compare byte arrays also, I don't need it in the tests.
from iris-java.
Yes, but what I meant, is that the data blobs concern the client of the library and not the binding itself. If the client wishes to put UTF-8 strings into the data blobs, so be it, if protobuf packets, then that is also fine.
I'm just saying that the two encodings (stings vs. the one used in the tests) are not tied together.
from iris-java.
You're right, fixed it
from iris-java.
Related Issues (20)
- Tunnel chunked send timeout bug
- Add tests for connection drop/teardown
- Use custom exceptions instead of the canned java ones HOT 1
- Port the latency and throughput benchmarks over HOT 2
- Write the API docs and annotations with javadoc
- Refactor the validators class
- Rewrite the readme based on the Go/Erlang version HOT 2
- Add contextual leveled logging support HOT 1
- Tunnel race HOT 3
- Finish queueing error log messages HOT 1
- Hide the public Tunnel constructor
- Leaking threads HOT 1
- Cannot send empty message over tunnel HOT 1
- Investigate validator regex performance HOT 1
- Maybe change API to use constructors instead of factory?
- Contention during the requests HOT 1
- Add a ClosedException for returning on pending and stale ops
- Swap out the ServiceHandler interface to an abstract class HOT 1
- Add tests for handling Iris node crashes
- Anomalies during notify and interrupt races
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iris-java.