Coder Social home page Coder Social logo

Hide the DEFAULT CHARSET about iris-java HOT 5 CLOSED

karalabe avatar karalabe commented on July 30, 2024
Hide the DEFAULT CHARSET

from iris-java.

Comments (5)

paplorinc avatar paplorinc commented on July 30, 2024

If I add it to the tests, I would repeat it's value. I have changed it to package private, since the tests use the same package.

from iris-java.

karalabe avatar karalabe commented on July 30, 2024

Not really, because the encoding of the data blobs are completely irrelevant from Iris's point of view and are independent of the strings. In essence, the encoding used within the protocol and the encoding in the tests are semantically different things.

But package private will do just fine.

from iris-java.

paplorinc avatar paplorinc commented on July 30, 2024

I can't rebuild the original String, if I don't know the original encoding.
But you're right, since I can compare byte arrays also, I don't need it in the tests.

from iris-java.

karalabe avatar karalabe commented on July 30, 2024

Yes, but what I meant, is that the data blobs concern the client of the library and not the binding itself. If the client wishes to put UTF-8 strings into the data blobs, so be it, if protobuf packets, then that is also fine.

I'm just saying that the two encodings (stings vs. the one used in the tests) are not tied together.

from iris-java.

paplorinc avatar paplorinc commented on July 30, 2024

You're right, fixed it

from iris-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.