Coder Social home page Coder Social logo

Comments (4)

ahocevar avatar ahocevar commented on June 18, 2024

@EkkoScholtens Thanks for the bug report. Your suggested code change makes sense. Would you be able to create a pull request?

from proj4js.

EkkoScholtens avatar EkkoScholtens commented on June 18, 2024

I can make the pull request for that issue. But i don't know what the issue is with the longitude. I believe this code is implemented from the book "Map Projections - A Working Manual" By JohnP. Snyder right?

from proj4js.

ahocevar avatar ahocevar commented on June 18, 2024

I don't know, the code was initially ported from C proj4. But looking again, your suggested code change should not produce a different result, as Math.atan(y / x) does the same as Math.atan(y, x). If you want to dig deeper, you can compare the implementation to the one in mproj's aeqd.js.

from proj4js.

EkkoScholtens avatar EkkoScholtens commented on June 18, 2024

You would expect that, but they do give different results in this use case. I've checked the PROJ source they do use atan which gives the correct result. However in new versions they made the switch to geographiclib which uses a different way to calculate the result.

from proj4js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.