programmiersportgruppe / akre Goto Github PK

Currently something like the following is necessary to use a RedisClient:

val actorSystem = ActorSystem("akre-example", ConfigFactory.parseString(
  """
  akka {
    actor.deployment {
      /akre-redis-pool {
        dispatcher = akre-coordinator-dispatcher
      }
    }
  }
  akre-coordinator-dispatcher {
    mailbox-type = org.programmiersportgruppe.redis.client.ResilientPoolMailbox
  }
  """))

This is inconvenient, and breaks the actorlessness of the RedisClient interface. The mailbox should get wired up on its own, and possibly also the dispatcher type.

There is a RedisClientAcceptanceTest case that checks that the RedisClient will "recover from the server going down nicely". It does this by sending a SHUTDOWN command to the server, then restarting the server, and immediately sending a SET command. The test can randomly fail with a 3-second AskTimeoutException when the SET command is sent before the ResilientPool gets the Terminated message informing it that the connection actor has died. The pool sends the command to the connection actor, but that actor dies before it processes the message. So the message becomes a dead letter and disappears into the ether, the pool receives the Terminated message and creates a new RedisConnectionActor, and the ask construct in RedisClient.execute eventually times out.

Since the actor system as a whole actually has the information that the SET command hasn't been sent to the server, it would be very nice if we could either resend it or at least fail quickly.

Currently very few commands are supported. We should support most commands.

Investigate hosting on GitHub using sbt-site and sbt-ghpages.