Comments (10)
Good catch! And thanks for saving me the trouble of having to ask you to pass on your mount data after realizing I was bug hunting in the wrong spot.
Habotica actually already does use mount data to determine which pets can be fed, but blindly assumes that either a mount exists or it doesn't. I didn't take into account that the key to the kennels will leave the entry but change the value. D'oh.
It's an easy fix though, now that we've pinpointed the problem. Google-Play-willing, you shouldn't have to wait more than a day or so for an update.
Unless you want to fix it yourself of course ;)
from hab-o-tica.
Thanks for the report! Believe it or not that's actually not a use case I've ever tested as I'm too much of a wuss to buy a kennel key. I'd been laboring under the assumption that standard pets were coded the same way as others, but apparently that was naive.
That leaves us with two options, depending on how tech-savvy you are. Either you have to wait for me build a test mode for Habotica so that I can easily reproduce your scenario, or you send me a copy of your userData.json.
I've been meaning to build a test mode for a while now, as that solves a number of other problems I've been having, so it's not that I mind doing that, but I'm afraid that would take a while.
With your userData.json it should probably be a really easy fix, but without some basic background in REST APIs I understand that might be a tall order. Please note that, if you do manage to get your hands on your userData.json file, I only need the pets
section. I heartily encourage you do delete everything else for obvious privacy reasons.
from hab-o-tica.
Thanks for looking into the issue. I'll take a closer look at my userData tomorrow and post here (currently on mobile).
from hab-o-tica.
Here's an excerpt from the userdata.json (most of the standard ones have value of 5 so no need to list them all).
"pets": {
"Wolf-Base": 5,
"TigerCub-Base": 5,
"FlyingPig-RoyalPurple": 10,
"Cactus-Desert": 5,
"FlyingPig-Base": 5,
"Wolf-RoyalPurple": 15,
"PandaCub-Base": 5,
"BearCub-Desert": 5,
"Jackalope-RoyalPurple": 5,
"PandaCub-Aquatic": -1,
"PandaCub-Desert": 5,
"BearCub-Golden": 5,
"Cactus-RoyalPurple": 10,
"TigerCub-Zombie": 5,
"Wolf-White": 5,
"TigerCub-Desert": 5,
"LionCub-CottonCandyBlue": 5,
...
}
from hab-o-tica.
Seems like that info alone cannot be used to determine which pets can be fed, as for example I have fed all bear cubs to mounts, but no other type of standard pets, but all of them still have value 5.
I guess you need to also look at the mounts
section from userdata.
Here's my for example:
"mounts": {
"PandaCub-Base": null,
"Orca-Base": true,
"Wolf-Base": null,
"Gryphon-RoyalPurple": true,
"PandaCub-Glass": true,
"Cactus-Desert": null,
"BearCub-Golden": true,
"Fox-Shade": null,
"LionCub-CottonCandyBlue": null,
"PandaCub-Aquatic": true,
"TigerCub-Zombie": null,
...
}
from hab-o-tica.
Fix has been released and should trickle it's way down to your phone in the next few hours. Please double-check that everything is working as it should. Without having reset my pets myself the fix is based on theory rather than empirically testing.
from hab-o-tica.
Can't see the update yet...
But I'll test it when it gets here. Thanks.
from hab-o-tica.
Still no update for me. Are you sure it went through ok? (it shows last update May 15)
from hab-o-tica.
Release was bounced by Google. Fixed it, so it should be rolled out soon. Thanks for keeping your eye on the ball!
from hab-o-tica.
Ok, now I got the update and it's working as expected. I can feed the pets until they grow to mounts. Thanks.
from hab-o-tica.
Related Issues (20)
- List all armoire results
- Optimize gear for skill use HOT 2
- Submit GitHub issues from within Habotica HOT 1
- Replace fugly button texts with shmancy icons HOT 1
- List skills results HOT 2
- Wardrobe to handle whole look HOT 2
- Brutal Smash doesn't work when on a challenge HOT 3
- Bump Android API version
- 64-bit support HOT 1
- [NEW] Haxx it button does nothing HOT 1
- FR: Only spam skill until boss is defeated HOT 1
- Reset last-used-skill on class change HOT 1
- Automated test suite
- [NEW] Hij is niet in de App store te vinden
- Fix vulnerability
- Label multiple tasks at once HOT 1
- Offer to hatch new pet
- Show mana pool in Use Skill dialog
- Bulk sell stuff
- Submit armoire request on keyboard submit
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hab-o-tica.