support 1.20.2 about node-minecraft-protocol

[SilkePilon]

Support will be added once you implement it and open a Pull Request. (No hard feelings)

[rom1504]

Check change in protocol.json in mcdata and also in wiki.vg/Protocol to understand things Notably configuration state was added

…

On Sat, Nov 18, 2023, 21:16 Tylar ***@***.***> wrote: an example error when trying to connect: (base) ***@***.***:~/repos/mineflayer$ node examples/looker.js localhost 25565 TypeError: Serialization error for login.toServer : Write error for undefined : Cannot read properties of undefined (reading 'length') at module.exports.Write.UUID (/home/tylar/repos/mineflayer/node_modules/minecraft-protocol/src/datatypes/compiler-minecraft.js:50:25) at Object.packet_login_start (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:708:26) at eval (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:754:62) at packet (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:760:9) at CompiledProtodef.write (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:76:12) at e.message (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:102:25) at tryCatch (/home/tylar/repos/mineflayer/node_modules/protodef/src/utils.js:50:16) at CompiledProtodef.createPacketBuffer (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:102:5) at Serializer.createPacketBuffer (/home/tylar/repos/mineflayer/node_modules/protodef/src/serializer.js:12:23) at Serializer._transform (/home/tylar/repos/mineflayer/node_modules/protodef/src/serializer.js:18:18) { field: 'login.toServer' } The 1.20.1 changelog <https://feedback.minecraft.net/hc/en-us/articles/19703470383757-Minecraft-Java-Edition-1-20-2> mentions "NETWORK PROTOCOL" changes. Without more details on that I don't know how to proceed. — Reply to this email directly, view it on GitHub <#1258 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437XWZHI3NMHMSXXRICDYFEJRDAVCNFSM6AAAAAA57U4LCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGYZDKNBTGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.*** com>

[lastuniverse]

It's a pity. If I succeed, I’ll definitely make a request

[kittenvr]

upvote

[Arthessia]

upvote here too :)

[lastuniverse]

Unfortunately, I won’t be able to deal with this issue for the next two weeks. It's a total mess at work.

[lastuniverse]

There is still a problem. Before updating node_minecraf_protocol to 1.20.2 you need to wait for the update https://github.com/PrismarineJS/minecraft-data

[lastuniverse]

I looked at https://github.com/PrismarineJS/minecraft-data .
Basically I'm not able to update minecraft-data without diving deep into it (((

[lastuniverse]

We are waiting for your reaction here PrismarineJS/minecraft-data#779

[SuchBlue]

https://github.com/PrismarineJS/minecraft-data now supports 1.20.2

[SuchBlue]

I have created a pull request #1261

[7yl4r]

an example error when trying to connect:

(base) tylar@laptop:~/repos/mineflayer$ node examples/looker.js localhost 25565
TypeError: Serialization error for login.toServer : Write error for undefined : Cannot read properties of undefined (reading 'length')
    at module.exports.Write.UUID (/home/tylar/repos/mineflayer/node_modules/minecraft-protocol/src/datatypes/compiler-minecraft.js:50:25)
    at Object.packet_login_start (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:708:26)
    at eval (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:754:62)
    at packet (eval at compile (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:258:12), <anonymous>:760:9)
    at CompiledProtodef.write (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:76:12)
    at e.message (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:102:25)
    at tryCatch (/home/tylar/repos/mineflayer/node_modules/protodef/src/utils.js:50:16)
    at CompiledProtodef.createPacketBuffer (/home/tylar/repos/mineflayer/node_modules/protodef/src/compiler.js:102:5)
    at Serializer.createPacketBuffer (/home/tylar/repos/mineflayer/node_modules/protodef/src/serializer.js:12:23)
    at Serializer._transform (/home/tylar/repos/mineflayer/node_modules/protodef/src/serializer.js:18:18) {
  field: 'login.toServer'
}

The 1.20.1 changelog mentions "NETWORK PROTOCOL" changes.
Without more details on that I don't know how to proceed.

[Parker2991]

also happens in node-minecraft-protocol but something about the uuid