Still disconnects when using node-minecraft-protocol/blob/master/examples/proxy/proxy.js about node-minecraft-protocol

[lastuniverse]

still this error appears

PartialReadError: Read error for undefined : undefined
    at new ExtendableError (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/utils.js:63:13)
    at new PartialReadError (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/utils.js:70:5)
    at Object.readBool [as bool] (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/datatypes/utils.js:133:41)
    at eval (eval at compile (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/compiler.js:258:12), <anonymous>:2966:29)
    at Object.packet_damage_event (eval at compile (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/compiler.js:258:12), <anonymous>:2972:9)
    at eval (eval at compile (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/compiler.js:258:12), <anonymous>:3011:64)
    at packet (eval at compile (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/compiler.js:258:12), <anonymous>:3100:9)
    at CompiledProtodef.read (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/compiler.js:70:12)
    at e.message (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/compiler.js:111:49)
    at tryCatch (/home/roman/work/minecraft_advanced_proxy/proxy/node_modules/protodef/src/utils.js:50:16)

[PondWader]

The damage_event packet errors will be fixed once a new release of minecraft-data is published.

See PrismarineJS/minecraft-data#738

[lastuniverse]

Thank you very much for your response. Looking forward to fixes.

[PondWader]

Thank you very much for your response. Looking forward to fixes.

You can update now to the latest unreleased mc data by doing:

cd node_modules/minecraft-data
rm -rf minecraft-data
git clone https://github.com/prismarinejs/minecraft-data

And see if that fixes your issues.

[lastuniverse]

Thanks a lot, I'll post the results

[lastuniverse]

There is no more crash due to damage (no error, no disconnect). But there is a strange disconnect in the following situation.
In the server settings, spawning of mobs, npc and monsters is disabled. Connected to the server through a proxy. Spawn zombies with the /summon ... command. Visually, nothing happens, no zombies appear. After a dozen seconds, a disconnect occurs or a zombie appears, which has been running after me for a long time. With the disconnect option, there are no errors in the proxy console, there is only a message
client.disconnect {myNick} {myUUID}

[lastuniverse]

There is a suspicion that this is not directly related to the mobs. Periodically, there are many situations when it seems that packets from the server do not reach the client and vice versa. Feeling as if the network is lag. This usually ends with a disconnect, within a few tens of seconds. When I restart, I often find that the actions performed before the disconnect were not applied.

In justification, I will say that I have a powerful processor, 64 gigabytes of RAM, the server, proxy and client communicate with each other via localhost. Moreover, if you go directly (not through a proxy), such situations do not arise.

I think that the reason is in the internal data processing mechanisms inside the proxy. Perhaps it hangs on some of the packets transmitted between the server and the client, but so far it has not been possible to calculate on which ones.

[lastuniverse]

Here is an example of how it happens
https://youtu.be/HIMi-PWQucc

[PondWader]

This may be happening due to proxying of the bundle_delimiter packet which can result in the client getting stuck, as it witholds packets but for some reason the packets do not get released correctly. I suspect this is due to how NMP handles the bundle delimiter internally whilst also emitting it.

You could try filtering out the bundle_delimiter packet, as a packet not to proxy and that issue will probably stop.

This is something I may look in to.

[PondWader]

Ah yes, I see the problem with NMP, I'll PR a fix tomorrow.

[lastuniverse]

Filtered out the bundle delimiter.
if (meta.name === "bundle_delimiter") return;

The proxy has been working without failure for half an hour. I'll leave it until the morning, if it doesn't disconnect or disconnect, I'll unsubscribe. Thank you for your help!

[lastuniverse]

I caught a nodejs crash in the morning (a process with a proxy) due to out of memory.
I will observe where exactly the memory is leaking and unsubscribe as I find out

[lastuniverse]

Thank you very much, now everything works flawlessly.