fail when there is a pending migration and out of order migrations are not allowed about goose

[mfridman]

Yes you're right, we had a check for this exact case in the methods themselves. I was really hoping to optimize this, but it looks like we still have to list all migrations even in the allow missing (out-of-order) case.

goose/provider_run.go

Lines 40 to 64 in 7e6240d

	// feat(mf): It is very possible someone may want to apply ONLY new migrations and skip missing
	// migrations entirely. At the moment this is not supported, but leaving this comment because
	// that's where that logic would be handled.
	//
	// For example, if db has 1,4 applied and 2,3,5 are new, we would apply only 5 and skip 2,3. Not
	// sure if this is a common use case, but it's possible.
	if len(missingMigrations) > 0 && !p.cfg.allowMissing {
	var collected []string
	for _, v := range missingMigrations {
	collected = append(collected, strconv.FormatInt(v, 10))
	}
	msg := "migration"
	if len(collected) > 1 {
	msg += "s"
	}
	var versionsMsg string
	if len(collected) > 1 {
	versionsMsg = "versions " + strings.Join(collected, ",")
	} else {
	versionsMsg = "version " + collected[0]
	}
	return nil, fmt.Errorf("found %d missing (out-of-order) %s lower than current max (%d): %s",
	len(missingMigrations), msg, dbMaxVersion, versionsMsg,
	)
	}

[mfridman]

Alright, #762 should fix that issue. It effectively calls the same method the internal up methods call, which handles the allowed missing (out-of-order) logic.

I also updated the test to make sure we captured this behavior.

One thing remaining is to think through the behavior of CheckPending, #762 (comment)