pranavraja / apns Goto Github PK

The Connect() function takes filesystem paths to the certificate and private key files. That's too limiting — the server may not have filesystem storage available, or the private key may be considered too sensitive so it might be kept in a Keychain-like store or an LDAP server.

Probably the most flexible way to do this would be for Connect() to take a tls.Certificate as a parameter, and let the caller load the certificate by calling either LoadX509KeyPair or X509KeyPair, the latter of which takes the components as raw byte arrays.

(I just filed the exact same issue as huo-ju/Go-Apns#3. Apologies for copying and pasting the text, but the issue with both packages is identical.)

Unintuitively, calling apns.ReadInvalid will return a non-nil error value if there are no invalid notifications, as the only way of determining whether there were no invalids is by allowing the socket read to timeout.

To resolve, either need to improve the documentation around this or add code to swallow the error in ReadInvalid.

in your example, ApnsService connect to APNS and use it to send messages, but i can't find any code closing the connection.