prajwel / curvit Goto Github PK

Good project! I want more like this.

Would you be kind enough to cite gPhoton, which seems to be a clear precursor to this effort?

https://github.com/cmillion/gphoton

See section 4.2 of the Curvit paper. Perhaps can be addressed in the software itself.

UVIT has three different filter naming conventions. The filter table provided in the Curvit article (See Table 3 from https://doi.org/10.1007/s12036-020-09680-5) should be added to the Curvit documentation website. This will help people to recognize the filters.

Many changes and new features are available. Update documentation to reflect all that.

The current code design seems to be a mess, with duplicate code at many locations. This has to be fixed.

This is due to due to readthedocs/readthedocs.org#10290.

Presently, curvit requires bins of particular seconds for generating lightcurve.

1. I request a way to get counts per orbit. This is particularly useful for variables witch have larger periods or observations that were done over multiple epochs.

In the present version, if we give a 500s bin, some counts before/after the bin may be ignored due to incomplete coverage, or an orbit with ~400 s is/should be ignored.
With the proposed approach, the bins will be equal to orbits, so all the events are utilized.

2. Currently, there are no errors (~ binwidth/2) in the time values. If you add the per orbit counts, you should also add the error/width of each data point in the output file.

Currently, errors are estimated assuming Poisson statistics. However, if there is significant saturation, the errors could be underestimated. See

N. P. M. Kuin, S. R. Rosen, The measurement errors in the Swift-UVOT and XMM-OM, Monthly Notices of the Royal Astronomical Society, Volume 383, Issue 1, 1 January 2008, Pages 383–386, https://doi.org/10.1111/j.1365-2966.2007.12549.x

Currently, the curve and curve_orbitwise functions generated source_*png and source_zoomed_*png files do not have the input source coordinates included in the filenames.

Explicitly mention that the estimated background is scaled to the aperture size.