praeclarum / bind Goto Github PK

Can we get a NuGet package of this? Thanks!

Within Bind.cs, around line 100, I would propose to check for read-only property using CanWrite:

            } else if (p != null) {
                if(p.CanWrite) {
                    p.SetValue(target, value, null);
                }

Object reference not set to an instance of an object. Android not supported?

I have a change proposal for
public static object EvalExpression (Expression expr)

Instead of:

return lambda.Compile ().DynamicInvoke ();

you could do this:

var deleg = lambda.Compile ();
try {
    return deleg.DynamicInvoke ();
}
catch (Exception ex) {
    return null;
}

This prevents the application from crashing whenever the expressen called via DynamicInvoke throws an exception. Any contraindication?

Otherwise, bindings don't work

Solution : comment line
((v is IComparable) && ((IComparable)v).CompareTo(Value) != 0))

in method

void OnSideChanged(Expression expr, Expression dependentExpr, int causeChangeId)

Solution :

Add to RemoveMemberChangeAction method this line objectSubs.Remove(key);

` internal static void RemoveMemberChangeAction(MemberChangeAction sub)
{
var key = Tuple.Create(sub.Target, sub.Member);
MemberActions subs;
if (objectSubs.TryGetValue(key, out subs))
{
// Debug.WriteLine ("REMOVE CHANGE ACTION " + sub.Target + " " + sub.Member);
subs.RemoveAction(sub);

            objectSubs.Remove(key);
        }
    }`

@praeclarum Any plans on continuing the development on this? would this work as-in in a Xamarin.Android (non-forms) implementation?

Awesome Frank! Have you tried this with a basic WinForm/WPF app? I may be an idiot and fresh off vacation but doesn't seem to be working as I change values in the textboxes...

I think there should really be value converters in here. Besides classic IValueConverter there could be simply a pair of Func<TIn,TOut> being passed to binding method.