practicingruby / prawn-layout Goto Github PK

This snippet of code doesn't work properly on Prawn master and 0.7.1, it runs without stopping, like an infinite loop or something.

Prawn::Document.generate("wide_table.pdf") do
  data = []
  data << ["English 12 S1", "Shalabi", "some long text " * 20]
  table data
end

tested under Ruby 1.9.1p378 and ruby 1.8.6p287.

Basically, Prawn is not able to handle very long text in table() when the :column_widths option is not specified. It is able to handle text at certain lengths, for example, in the above snippet, if the multiplier was 16 instead of 20 it works.

I think Prawn should either be able to handle it, or at least raise an exception when it can't, but not loop forever.

Thanks

When building a table everything looks good on the first page but the content on any additional page is completely black. Below is some sample code that shows the error. Comment out the :row_colors option and everything works fine.

  table(
    (1..45).map { [ "foo"] },
    :row_colors => ["DBDBDB", "FFFFFF"],
    :position => :center
  )

:overflow => :shrink_to_fit does not work if the following conditions occur:

A text box has the same width and height as the bounding_box, which has the same width and height as the grid box we are using for positioning.

The latter with grid box size may be irrelevant, but this was my setup when the bug appeared.
Text which overflowed just disappeared.

:shrink_to_fit started working when i decreased the height and width of the text_box to be smaller than the bounding box.

if you start a footer with a top-left x-coordinate of 38 or greater, stuff gets cut off. To illustrate:

footer [38, margin_box.bottom] do
    stroke_horizontal_rule
    text "Align right footer", :align => :right
end

[Description edited by bradediger]

When a the data for a table includes cells or hashes that specify :font_style and :font_size (possibly other attributes as well), the natural width calculation for the table is wrong.

Specced in bneumeier/prawn-layout@2024b97.

Patch in bneumeier/prawn-layout@cfaffbf looks correct but carries a big refactor of prawn-layout that conflicts with the nested table changes for 0.7. It also adds colspan to Cell, which, as discussed on prawn-ruby, is suboptimal. If we can rebase these changes on top of the new prawn-layout, that would be perfect.

Would be useful for go_to_page and other things, returns the current page number.

Currently it's shown only on first page. But the grid is actually defined for all pages.

Working on a patch.

I am struggling with an unwanted page break in a table. The contents of the cells varies in length. It seems some specific combinations of text length trigger the page break. Some much longer texts are displayed without a page break.

Here is the shortest snippet I found that has the page break. (I'm not using the font_size change in my app, it just happens to trigger the problem here.)

require 'rubygems'
require 'prawn/core'
require 'prawn/layout'
Prawn::Document.generate("problem.pdf") do
  @table = [[
    Prawn::Table::Cell.new(:text => "Some text with overflow.\nAnother line"),
    Prawn::Table::Cell.new(:text => 'foo'),
  ]]

  (8..9).each do |i|
    table @table, {:column_widths => { 0 => 100, 1 => 100}, :font_size => i}
  end
end

This happened in 0.5; I've built the gem from github and it's the same.

When running the specs I get two failures:

1. Failure:
   test_spec {A document's grid when a grid is defined} 005 [should draw outlines without changing global default colors to grid color](A document's grid when a grid is defined)
   [./spec/grid_spec.rb:70:in test_spec {A document's grid when a grid is defined} 005 [should draw outlines without changing global default colors to grid color]' /usr/lib64/ruby/gems/1.8/gems/mocha-0.9.8/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:19:insend'
   /usr/lib64/ruby/gems/1.8/gems/mocha-0.9.8/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:19:in `run']:
   <[0.0, 0.0, 0.0]> expected but was
   .

2. Failure:
   test_spec {A document's grid when a grid is defined} 006 [should draw outlines without curent color settings](A document's grid when a grid is defined)
   [./spec/grid_spec.rb:81:in test_spec {A document's grid when a grid is defined} 006 [should draw outlines without curent color settings]' /usr/lib64/ruby/gems/1.8/gems/mocha-0.9.8/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:19:insend'
   /usr/lib64/ruby/gems/1.8/gems/mocha-0.9.8/lib/mocha/integration/test_unit/ruby_version_186_and_above.rb:19:in `run']:
   <[0.8, 1.0, 0.0]> expected but was
   .

30 tests, 45 assertions, 2 failures, 0 errors

I've made sure to run these against prawn-core 0.8.4, but I saw the same failures with prawn-core 0.7.1. Please let me know if more information is needed.

When having multiple unique tables formatted in a bounding_box start_new_page is added after each.

Originally reported by eeabed (Abdul-Jabbar Shalabi):

After upgrading to Prawn 0.7.1, I noticed that table() doesn't respect the current color setting by fill_color(), only the first cell will have text color according to it, but subsequent cells will have just black text.

example:

fill_color "ff0000"
table [%w[1 2 3],%w[4 5 6],%w[7 8 9]], 
  :position => :center,
  :border_width   => 0,
  :font_size => 40

Only the first cell in the above table has red text color, the rest is just black.
Expected: all text should be red.

Maybe it is worth it to add a :text_color option for table() for setting text color, as we have for headers (:header_text_color)

See issue over in Prawn tracker:
http://github.com/sandal/prawn/issues#issue/19

(Plz file future prawn-layout bugs here, of course :)

See: http://github.com/blaxter/prawn-layout/commits/master

While trying to work with column_box I found out that plain text works well but tables don't flow properly.

This works fine:

column_box [0,cursor], :width => bounds.width, :columns => 2 do
  text " This is a test " * 100
end

This just causes the tables to continue in the first column over multiple pages, never flowing into the second column:

column_box [0,cursor], :width => bounds.width, :columns => 2 do
  table data, :headers => headers,
    :header_color => 'C0C0C0',
    :font_size    => 7,
    :border_style => :grid,
    :border_width => 0.5,
    :width        => bounds.width-10
end 

I have repeatable header and footer. and I created a table and added to bounding box.

is there any super easy option to avoid overlaping page header and table header?.

Git repository is correct, but the code in the 0.7.1 gem for some strange reason does not include the header and footer methods. Using gem from here:

http://gemcutter.org/gems/prawn-layout

Sam.

Added some new table options. See shammond42/prawn-layout (http://github.com/shammond42/prawn-layout) for implementation. The following options have been implemented.

• :column_color => shade a column of table cells
• rows border style
• outline border style

Also fixed a couple of border rendering bugs that became apparent with the above border styles.

When using show_all for on a grid, the stroke color isn't reset afterwards. This is an undesired side effect.

Working on a patch, will post when ready.

Reported by Simon Hürlimann:

There's some regression in drawing tables.
When using a small vertical_padding (like 0 or 1), a page break is inserted after each cell. Cell borders are on the previous page than the content, though.

It looks like the commit to prawn-core 63dd5c8 (Don't let descender protrude below bounds bottom. This is a change from pre-text-overhaul functionality.) seems to have introduced this behaviour.

You may reproduce ith git versions
prawn-layout c13d2ce - Really fixing this now prawn-core 63dd5c8 - Don't let descender protrude below bounds bottom. This is a change from pre-text-overhaul functionality.

this wraps page for every cell for default font:
pdf.table([['Test', 'Val'], ['Test', 'Val']], :vertical_padding => 1)

It got somehow better during the development towards 0.7.1. The problem doesn't show anymore with the default font, but can still be triggered by some other fonts and smaller vertical_padding. I've experienced it with some proprietary TTF font called "Cholla Sans" with vertical_padding = 1. It also shows with the free TTF font "DejaVu Sans" and the built in font "Times-Roman" and vertical_padding = 0.

With
prawn-layout 0.7.1 prawn-core 0.7.1

it works for the default font, but still wraps for every cell for "Cholla" font with padding => 1 and "DejaVuSans", "Times-Roman" with padding => 0:
pdf.font('Times-Roman') pdf.table([['Test', 'Val'], ['Test', 'Val']], :vertical_padding => 0)

Minimal reproducing example:

  require 'prawn/core'
  require 'prawn/layout'

  pdf = Prawn::Document.new
  pdf.font('Times-Roman')
  pdf.table([['Test', 'Val'], ['Test', 'Val']], :vertical_padding => 0)
  pdf.render_file('test.pdf')

Hi,

if I create a document with table I get an error with the Acrobat Reader 9.x

"An error exists on this page. Acrobat may not display the page correctly. Please contact the person who created the PDF document to correct the problem."

The error occurs only if I use more then six columns in my table.

For example following code works fine without errors:

data = [['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow'],
['Gregory Brown', 'Gregory Brow', 'Gregory Brow','Gregory Brow','Gregory Brow'],
['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow','Gregory Brow'],
['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow','Gregory Brow']] 

pdf.table data 
end 

If I add some columns I get the display error. Following code reproduce it.

data = [['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow','Gregory Brow','Gregory Brow','Gregory Brow'],
['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow','Gregory Brow','Gregory Brow'],
['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow','Gregory Brow', 'Gregory Brow','Gregory Brow'],
['Gregory Brown', 'Gregory Brow', 'Gregory Brow', 'Gregory Brow','Gregory Brow','Gregory Brow','Gregory Brow']]

pdf.table data 
end 

Mac Preview and Foxit Reader are working without errors.

Here is the link to a commit where I replace translate! with 'map_to_absolute'.

The tests and examples seems to pass just fine.

http://github.com/cassiomarques/prawn-layout/commit/220cda17cda0eb8aca772947f3f2f488ba2e40e8

Defect documented in:
bugs/table_spacing_calculations.rb

Note also:

"If you specify the text :size outside of the table element the cell spacing is not adjusted properly and stays at the default size. However, if you specify the :font_size in the table it works properly.

This fails: text_options.update(:size => 7) table(data)

This works properly: table data, :font_size => 7"