ppazos / openehr-rest-client Goto Github PK

The conformance is currently running with a hardcoded HTTP header for representation details (Prefer: return=representation) and it is expecting resolved references in the creation of EHRs (EhrDto). We can support both behaviours by allowing defining these headers, returning EhrDto when configured to resolve references (i.e. Prefer: return=representation, resolve_refs) and Ehr if not (i.e. Prefer: return=representation).

Since error messages are not part of the specs and will vary quite a lot between implementations, I would suggest we check HTTP status codes instead. Those are included in the specs and should be implementation agnostic.

We should have a way of disabling authentication if it's not required

When testing the EHR endpoint we could use random UUIDs instead of fixed ones, that way there is no need to truncate the Db each time we run the test.

EHR
EHR_STATUS
COMPOSITION
FOLDER
CONTRIBUTION
ADL
OPT
QUERY
ACTOR
PARTY_RELATIONSHIP

This is now hardcoded https://github.com/ppazos/openehr-rest-client/blob/master/src/main/groovy/com/cabolabs/openehr/rest/client/OpenEhrRestClient.groovy#L138

Maybe by presetting them before calling the commit services.

We should provide a simple way of passing this parameter when running the tests, without needing to change the application.properties file in the project

Project is using old groovy dependencies (2020) and there are some problems using the latest JDK. I'd suggest we move to groovy-all:3.0.17 and spock-core:2.3-groovy-3.0. Gradle could also be updated to 7.6

For this we need serialization for OPT to XML in the SDK ppazos/openEHR-OPT#83

It should be possible to run the tests with or without DB truncation

Some of the tests are performing unnecessary calls to the truncateServer() method during the cleanup phase