Coder Social home page Coder Social logo

jammming's People

Contributors

powernerd avatar

Stargazers

 avatar

Watchers

 avatar

jammming's Issues

Comments

Great use of comments. This will make the code easier to understand for self or any other users. You can also comment in the render function by placing the comments in {} like so

{/*comment*/}

Summary

Really appreciate the intuitive and original approach. the coding was very good and easy to understand. The functions as it should. The only additional material I would suggest covering is states. This document will help with handling states;

https://reactjs.org/docs/state-and-lifecycle.html

addTrack

The addTrack function can be more concise like so

 addTrack(track) {
    let tracks = this.state.playlistTracks;
    if (!tracks.includes(track)) {
      tracks.push(track);
      this.setState({playlistTracks: tracks});
    }
} 

componentWillMount

It is not best practice to store a function inside the constructor like this

class App extends React.Component {
  constructor(props) {
    super(props);
..........................................
    Spotify.getAccessToken();
}
}

The best place to put it is in componentWillMount. That will trigger the function as soon as its loaded. You can can get more information on that here;

https://reactjs.org/docs/react-component.html

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.