posva / p-singleton

Ensure only one instance of a promise is created until rejected or resolved

Keeping the Vue Ecosystem enjoyable ⚡️
www ᐧ X ᐧ Mastering Pinia 🍍 ᐧ sponsor

p-singleton's Issues

Use Function.apply instead of Function.call

Shouldn't this:

const promise = fn.call(this, args)

instead be this?

const promise = fn.apply(this, args)

That way you don't have to manually unpack the arguments inside the callee.

SyntaxError on IE11

As Babel is not applied to node_modules usually in most of projects this package is not transpiled and throws an error in browsers that do not support modern EcmaScript.

Even if it will be included to Babel it will fail in Webpack because Babel with option presets: [ ['@babel/preset-env', { useBuiltins: 'usage'}] ] will add import 'core-js/some-polyfill to almost every file including this package. This produces a sutation when we have import and module.exports in a single file which is a known problem. Webpack will switch to strict mode and not allow to modify module.exports. This package will throw an error that module.exports is read-only

Possible solutions:

• The best solution I see is to manually rewrite everything to ES5. Fortunatly the code base is not large
• Add build tasks with transpilation and publish built code

Lets discuss and I can help with an implementation

Dependency Dashboard

This issue provides visibility into Renovate updates and their statuses. Learn more

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update dependency jest to ^27.2.2

---

• Check this box to trigger a request for Renovate to run again on this repository