postfinance / httpclient

Generates a HTTP client from a service definition (interface). The created client is ready to use in production with many configuration options and sensible defaults.

httpclient

Generates a HTTP client from a service definition (interface). The created client is ready to use in production with many configuration options and sensible defaults.

Requirements

Go 1.7

Installation

# go get -u github.com/postfinance/httpclient/cmd/httpclient-gen-go

Usage

See example

httpclient's Issues

v2 discussion

Custom Response
Instead of http.Response return a httpclient.Response like:

type struct httpclient.Response {
  *http.Response
  reqDump []byte
  bodyDump []byte
}

This could possibly fix #8 .

It would add the possibility to add a Dump method which dumps request or response.

Debug Option
Add Debug option to dump requests and responses.

Do not export RequestCallback and ResponseCallback
Use an unexported slice of callbacks and append custom callbacks. If we initiate the slice with the default error handler we do not need additional documentation for error handling

Propagate error.

Make options thread-safe
Currently it is possible to change an already initiated client with the functional options. For example it is possible to change the http.client with httpclient.WithHTTPClient

Do not embed Client in struct.

Support for application/vnd.api+json

https://stackoverflow.com/questions/28055526/header-value-application-vnd-apijson

handle body in case of error (http.StatusCode != 2xx)

In case of error (http.StatusCode != 2xx) there might be additional information in the body. Currently Unmarshaler will not be called, if ResonseCallback returns an error.