Coder Social home page Coder Social logo

Inconsistent source end location about postcss HOT 6 CLOSED

idoros avatar idoros commented on June 8, 2024 1
Inconsistent source end location

from postcss.

Comments (6)

ai avatar ai commented on June 8, 2024

I am busy on another open source project and since there is no real problem, I don’t plan to spend my time.

You can investigate and send PR, I will help you.

from postcss.

idoros avatar idoros commented on June 8, 2024

I understand that a quick solution might not be readily available, and I'm perfectly fine with putting in the effort 😊.
Just wanted to make sure that I'm not missing anything and document the issue.

I will try looking into the code hopefully next week. If there are any specific tests or relevant code segments that you could direct me to, I would greatly appreciate it. Thank you in advance!

from postcss.

idoros avatar idoros commented on June 8, 2024

I ended up looking into this yesterday after work and I think I have a solution.

Now, I could use your help on the testing front. I've thrown together some "unit" tests in a file called location.test.ts to help me troubleshoot the different cases.

I still have failing tests coming from postcss-parser-tests with their expected JSON need adjustments. What is the process of updating postcss-parser-tests? for now, I opened the PR without addressing them so we can focus on the fix.

from postcss.

ai avatar ai commented on June 8, 2024

What is the process of updating postcss-parser-tests?

Clone postcss and postcss-parser-tests to dirs near each other:

  • Dev/
    • postcss/
    • postcss-parser-tests/

Fix postcss and then:

cd ../
cd postcss-parser-tests
./test/update.js

Then send PR to postcss-parser-tests with changed JSONs.

from postcss.

idoros avatar idoros commented on June 8, 2024

done

from postcss.

ai avatar ai commented on June 8, 2024

The fix was released at 8.4.29. Thanks.

from postcss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.