portlandcodeschool / ruby-on-rails-2014q1

Courseware for the first Ruby on Rails class of 2014

PortlandCodeSchool.com Redesign

This repo is for the redesign of the Portland Code School website. Please see the wiki for more details.

This site will be built using Middleman, Heroku, Font Awesome by Dave Gandy and Bootstrap.

Beta testers now welcome! Please check out Heroku staging site and file an issue if you find any problems, or have suggestions for improvements.

All contributors are encouraged to read the documentation for each of these before submitting code.

ruby-on-rails-2014q1's Issues

Another bug in spec file.

There is a duplicate test in the name_parser_spec.rb file.

The rule states:

it "should parse prefixes and last names and suffixes" do
return_array = Parse.parse_names(prefixes, suffixes, "Lady Madona III")
expect (return_array).to eq(["Lady","","","Madona","III"])
end

This is a duplicate rule and might cause a conflict in your tests if the rule is ran twice.

CC03: there's a test that conflicts with the rules of the spec

code_challenge_03/txt2csv/spec/name_parser_spec.rb

The rule below states:

If there is a middle name or a last name, there will be a first name. (For "M. Jackson", "M." is the first name.) There is always a last name (For "Miss Jane," "Jane" is a last name)

However there's a test that appears to conflict with the rule?

it "should parse prefixes and last names" do

return_array = Parse.parse_names(prefixes, suffixes, "Lady Madona")
expect(return_array).to eq(["Lady","","","Madona",""])

end

which is correct?

Thanks
Jin

CC03: There's a couple of bugs on the tests

code_challenge_03/txt2csv/spec/name_parser_spec.rb

Last test: it "should parse the whole banana" do

The passed string is missing the first name that the test is looking for: "Mary"

it "should parse the whole banana" do
return_array = Parse.parse_names(prefixes, suffixes, "Lady Samuel Madona-Richey III")
expect(return_array).to eq(["Lady","Mary","Samuel","Madona-Richey","III"])
end

I Code Challenge 02: I think there's a typo in the document -file name doesn't match instruction

What's written in the instructions:

step 4: +1. In the txt2csv folder, run the acceptance tests using the command

• "rspec spec/analyze.rb" and watch them fail.

what should be in the instructions:
+1. In the txt2csv folder, run the acceptance tests using the command

• "rspec spec/analyze_spec.rb" and watch them fail.

week1 HW, no contact list

There is no contact list on google docs owned by either Shawna or Chris. Chris said he will make a new one in an email I got CCd in.

This was listed in the "Connect up to the community" area.

CC03: there's a test that conflicts with the rules of the spec

code_challenge_03/txt2csv/spec/name_parser_spec.rb

The rule below states:
If there is a middle name or a last name, there will be a first name. (For "M. Jackson", "M." is the first name.)

* There is always a last name (For "Miss Jane," "Jane" is a last name)

However there's a test that appears to conflict with the rule?

it "should parse prefixes and last names" do

return_array = Parse.parse_names(prefixes, suffixes, "Lady Madona")
expect(return_array).to eq(["Lady","","","Madona",""])

end

which is correct?

Thanks
Jin